[vala/staging] vala: Drop unused MemberAccess.creation_member property API

[Rico Tzschichholz <ricotz src gnome org>]

commit 35c641ffe04f72b17b8d929eb3a3688922f7e718
Author: Rico Tzschichholz <ricotz ubuntu com>
Date:   Tue Feb 22 13:10:20 2022 +0100

    vala: Drop unused MemberAccess.creation_member property API

 vala/valagenieparser.vala     | 6 ------
 vala/valainitializerlist.vala | 1 -
 vala/valamemberaccess.vala    | 7 +------
 vala/valaparser.vala          | 2 --
 4 files changed, 1 insertion(+), 15 deletions(-)
---
diff --git a/vala/valagenieparser.vala b/vala/valagenieparser.vala
index 0b0e242e3..7c7c48309 100644
--- a/vala/valagenieparser.vala
+++ b/vala/valagenieparser.vala
@@ -946,7 +946,6 @@ public class Vala.Genie.Parser : CodeVisitor {
                if (init_list.size > 0 && inner is MemberAccess) {
                        // struct creation expression
                        var member = (MemberAccess) inner;
-                       member.creation_member = true;
 
                        var expr = new ObjectCreationExpression (member, get_src (begin));
                        expr.struct_creation = true;
@@ -1065,7 +1064,6 @@ public class Vala.Genie.Parser : CodeVisitor {
        }
 
        Expression parse_object_creation_expression (SourceLocation begin, MemberAccess member) throws 
ParseError {
-               member.creation_member = true;
                List<Expression> arg_list;
                if (accept (TokenType.OPEN_PARENS)) {
                        arg_list = parse_argument_list ();
@@ -1145,8 +1143,6 @@ public class Vala.Genie.Parser : CodeVisitor {
                list_member = new MemberAccess (parent_member, "ArrayList", get_src (begin));
                list_member.add_type_argument (element_type);
 
-               list_member.creation_member = true;
-
                var expr = new ObjectCreationExpression (list_member, get_src (begin));
                return expr;
        }
@@ -1160,8 +1156,6 @@ public class Vala.Genie.Parser : CodeVisitor {
                dict_member.add_type_argument (key_type);
                dict_member.add_type_argument (value_type);
 
-               dict_member.creation_member = true;
-
                var expr = new ObjectCreationExpression (dict_member, get_src (begin));
 
                return expr;
diff --git a/vala/valainitializerlist.vala b/vala/valainitializerlist.vala
index 87165439d..5b33aad45 100644
--- a/vala/valainitializerlist.vala
+++ b/vala/valainitializerlist.vala
@@ -202,7 +202,6 @@ public class Vala.InitializerList : Expression {
                        if (in_array_creation_initializer) {
                                unowned Symbol? sym = st;
                                var ma = new MemberAccess.simple (sym.name, source_reference);
-                               ma.creation_member = true;
                                ma.symbol_reference = sym;
                                MemberAccess inner = ma;
                                while (sym.parent_symbol != null && sym.parent_symbol != context.root) {
diff --git a/vala/valamemberaccess.vala b/vala/valamemberaccess.vala
index 25d74fc88..33887cbec 100644
--- a/vala/valamemberaccess.vala
+++ b/vala/valamemberaccess.vala
@@ -62,11 +62,6 @@ public class Vala.MemberAccess : Expression {
         */
        public bool tainted_access { get; set; }
 
-       /**
-        * Specifies whether the member is used for object creation.
-        */
-       public bool creation_member { get; set; }
-
        /**
         * Qualified access to global symbol.
         */
@@ -904,7 +899,7 @@ public class Vala.MemberAccess : Expression {
                } else if (member is Signal) {
                        instance = true;
                        access = member.access;
-               } else if (!creation_member && member is ErrorCode) {
+               } else if (member is ErrorCode) {
                        symbol_reference = ((ErrorCode) member).code;
                        member = symbol_reference;
                }
diff --git a/vala/valaparser.vala b/vala/valaparser.vala
index d81fc3544..cfa0776ae 100644
--- a/vala/valaparser.vala
+++ b/vala/valaparser.vala
@@ -911,7 +911,6 @@ public class Vala.Parser : CodeVisitor {
                if (init_list.size > 0 && inner is MemberAccess) {
                        // struct creation expression
                        unowned MemberAccess member = (MemberAccess) inner;
-                       member.creation_member = true;
 
                        var expr = new ObjectCreationExpression (member, src);
                        expr.struct_creation = true;
@@ -1031,7 +1030,6 @@ public class Vala.Parser : CodeVisitor {
        }
 
        Expression parse_object_creation_expression (SourceLocation begin, MemberAccess member) throws 
ParseError {
-               member.creation_member = true;
                var arg_list = parse_argument_list ();
                var src = get_src (begin);