[gnote] virtual is excessive for methods marked override
- From: Aurimas Černius <aurimasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnote] virtual is excessive for methods marked override
- Date: Sun, 20 Feb 2022 17:57:51 +0000 (UTC)
commit 8164c486d35e20d5202f5a9d2c6e0219af9c3546
Author: Aurimas Černius <aurisc4 gmail com>
Date: Sun Feb 20 19:57:38 2022 +0200
virtual is excessive for methods marked override
src/actionmanager.hpp | 21 ++++++++++-----------
1 file changed, 10 insertions(+), 11 deletions(-)
---
diff --git a/src/actionmanager.hpp b/src/actionmanager.hpp
index 1796fec7..7489c4cb 100644
--- a/src/actionmanager.hpp
+++ b/src/actionmanager.hpp
@@ -38,21 +38,20 @@ class ActionManager
public:
void init();
- virtual Glib::RefPtr<Gio::SimpleAction> get_app_action(const Glib::ustring & name) const override;
+ Glib::RefPtr<Gio::SimpleAction> get_app_action(const Glib::ustring & name) const override;
const std::vector<Glib::RefPtr<Gio::SimpleAction> > & get_app_actions() const
{
return m_app_actions;
}
- virtual Glib::RefPtr<Gio::SimpleAction> add_app_action(const Glib::ustring & name) override;
- virtual void add_app_menu_item(int section, int order, Glib::ustring && label, Glib::ustring &&
action_def) override;
- virtual void register_main_window_action(Glib::ustring && action, const Glib::VariantType *state_type,
bool modifying = true) override;
- virtual std::map<Glib::ustring, const Glib::VariantType*> get_main_window_actions() const override;
- virtual bool is_modifying_main_window_action(const Glib::ustring & action) const override;
-
- virtual void register_main_window_search_callback(Glib::ustring && id, Glib::ustring && action,
- sigc::slot<void, const Glib::VariantBase&> callback)
override;
- virtual void unregister_main_window_search_callback(const Glib::ustring & id) override;
- virtual std::map<Glib::ustring, sigc::slot<void, const Glib::VariantBase&>>
get_main_window_search_callbacks() override;
+ Glib::RefPtr<Gio::SimpleAction> add_app_action(const Glib::ustring & name) override;
+ void add_app_menu_item(int section, int order, Glib::ustring && label, Glib::ustring && action_def)
override;
+ void register_main_window_action(Glib::ustring && action, const Glib::VariantType *state_type, bool
modifying = true) override;
+ std::map<Glib::ustring, const Glib::VariantType*> get_main_window_actions() const override;
+ bool is_modifying_main_window_action(const Glib::ustring & action) const override;
+
+ void register_main_window_search_callback(Glib::ustring && id, Glib::ustring && action, sigc::slot<void,
const Glib::VariantBase&> callback) override;
+ void unregister_main_window_search_callback(const Glib::ustring & id) override;
+ std::map<Glib::ustring, sigc::slot<void, const Glib::VariantBase&>> get_main_window_search_callbacks()
override;
private:
void make_app_actions();
void make_app_menu_items();
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]