[gnome-software/wip/wjt/no-parent-instance-in-private-structs] Remove parent instance from Private structs
- From: Will Thompson <wjt src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software/wip/wjt/no-parent-instance-in-private-structs] Remove parent instance from Private structs
- Date: Thu, 17 Feb 2022 17:47:25 +0000 (UTC)
commit b4424b9d5974c3ed2937dd1254f1fc8a86692842
Author: Will Thompson <wjt endlessos org>
Date: Thu Feb 17 17:42:28 2022 +0000
Remove parent instance from Private structs
A number of types were switched from G_DECLARE_FINAL_TYPE to
G_DECLARE_DERIVABLE_TYPE, and their structs renamed from GsFoo to
GsFooPrivate, but the first element, embedding the parent type, was not
removed.
This is unneeded in the Private structure. G_DECLARE_DERIVABLE_TYPE
defines an empty struct wrapping the parent.
lib/gs-app.c | 2 --
src/gs-loading-page.c | 2 --
src/gs-review-row.c | 2 --
3 files changed, 6 deletions(-)
---
diff --git a/lib/gs-app.c b/lib/gs-app.c
index 90b652d78..3e605a209 100644
--- a/lib/gs-app.c
+++ b/lib/gs-app.c
@@ -54,8 +54,6 @@
typedef struct
{
- GObject parent_instance;
-
GMutex mutex;
gchar *id;
gchar *unique_id;
diff --git a/src/gs-loading-page.c b/src/gs-loading-page.c
index ef53d4438..00764a318 100644
--- a/src/gs-loading-page.c
+++ b/src/gs-loading-page.c
@@ -15,8 +15,6 @@
#include "gs-loading-page.h"
typedef struct {
- GsPage parent_instance;
-
GsPluginLoader *plugin_loader;
GCancellable *cancellable;
GsShell *shell;
diff --git a/src/gs-review-row.c b/src/gs-review-row.c
index 0f9b98fd5..9afb4849b 100644
--- a/src/gs-review-row.c
+++ b/src/gs-review-row.c
@@ -15,8 +15,6 @@
typedef struct
{
- GtkListBoxRow parent_instance;
-
AsReview *review;
gboolean network_available;
guint64 actions;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]