[gnome-shell/wip/snwh/appgrid-regression-fixes] theme: Fixes to regressions in app grid

[Sam Hewitt <snwh src gnome org>]

commit f5564131e58df75f0b7d48560da55f6eea040faf
Author: Sam Hewitt <sam snwh org>
Date:   Tue Feb 15 12:30:51 2022 -0330

    theme: Fixes to regressions in app grid

 data/theme/gnome-shell-sass/widgets/_app-grid.scss    | 12 +++++-------
 data/theme/gnome-shell-sass/widgets/_dash.scss        |  8 ++++++--
 .../gnome-shell-sass/widgets/_search-results.scss     | 19 ++++++++-----------
 3 files changed, 19 insertions(+), 20 deletions(-)
---
diff --git a/data/theme/gnome-shell-sass/widgets/_app-grid.scss 
b/data/theme/gnome-shell-sass/widgets/_app-grid.scss
index 05a717519e..25e29ef648 100644
--- a/data/theme/gnome-shell-sass/widgets/_app-grid.scss
+++ b/data/theme/gnome-shell-sass/widgets/_app-grid.scss
@@ -6,12 +6,12 @@ $app_icon_size: 96px;
 .icon-grid {
   row-spacing: $base_padding * 2;
   column-spacing: $base_padding * 2;
-  max-row-spacing: $base_padding * 12;
-  max-column-spacing: $base_padding * 12;
+  max-row-spacing: $base_padding * 7;
+  max-column-spacing: $base_padding * 7;
   page-padding-top: $base_padding * 4;
   page-padding-bottom: $base_padding * 4;
-  page-padding-left: $base_padding * 2;
-  page-padding-right: $base_padding * 2;
+  page-padding-left: $base_padding * 3;
+  page-padding-right: $base_padding * 3;
 }
 
 /* App Icons */
@@ -20,9 +20,7 @@ $app_icon_size: 96px;
 .app-well-app {
   @include overview_icon($osd_fg_color);
 
-  .overview-icon {
-    padding: $base_padding*2;
-  }
+  .overview-icon {padding: $base_padding*2;}
   .overview-icon.overview-icon-with-label {
     > StBoxLayout {
       spacing: $base_padding;
diff --git a/data/theme/gnome-shell-sass/widgets/_dash.scss b/data/theme/gnome-shell-sass/widgets/_dash.scss
index 462e663271..25755e73d7 100644
--- a/data/theme/gnome-shell-sass/widgets/_dash.scss
+++ b/data/theme/gnome-shell-sass/widgets/_dash.scss
@@ -8,7 +8,7 @@ $dash_border_radius: $modal_radius + $dash_padding;
 // container for the dash
 #dash {
   @extend %caption;
-  margin: 2em;
+  margin: $base_margin * 3;
 
   .placeholder {
     // background-image: url("resource:///org/gnome/shell/theme/dash-placeholder.svg");
@@ -38,9 +38,12 @@ $dash_border_radius: $modal_radius + $dash_padding;
 
 // items on the dash
 .dash-item-container {
+  > * {margin: 0 2px;}
+  &:ltr:first-child {margin-left: 0;}
+  &:rtl:first-child {margin-right: 0;}
+
   // each app item on the dash
   .app-well-app .overview-icon {
-    margin: 0 4px;
     padding: $base_padding;
   }
 
@@ -51,6 +54,7 @@ $dash_border_radius: $modal_radius + $dash_padding;
 // separator between favourites and running apps
 .dash-separator {
   width: 1px;
+  margin: 0 $base_margin;
   background-color: $borders_color;
 }
 
diff --git a/data/theme/gnome-shell-sass/widgets/_search-results.scss 
b/data/theme/gnome-shell-sass/widgets/_search-results.scss
index 4ad3f08217..ab4c831cf7 100644
--- a/data/theme/gnome-shell-sass/widgets/_search-results.scss
+++ b/data/theme/gnome-shell-sass/widgets/_search-results.scss
@@ -2,14 +2,13 @@
 
 // search overview container
 #searchResultsContent {
-  max-width: 1024px;
-  spacing: $base_margin * 2;
+  max-width: 1072px;
 }
 
 // search results sections "the boxes"
 .search-section {
   // This should be equal to #searchResultsContent spacing
-  spacing: $base_margin * 2;
+  spacing: $base_padding*3;
 
   // separator (unstyled)
   .search-section-separator { 
@@ -23,27 +22,23 @@
   background-color: lighten($system_bg_color, 5%);
   border-radius: $modal_radius*1.5;
   border: 1px solid $osd_outer_borders_color;
-  box-shadow: none;
-  text-shadow: none;
   color: $osd_fg_color;
   padding: $base_padding*2;
-  margin: $base_margin;
-  // This is the space between the provider icon and the results container
+  margin:$base_margin 0;
 }
 
 %search_section_content_item {
   @include tile_button($osd_fg_color);
-  margin: $base_margin;
-  border-radius: $base_border_radius !important;
+  border-radius: $base_border_radius+3px;
 }
 
 // "no results" text
 .search-statustext {
-  @extend %large_title;
+  @extend %title_1;
 }
 
 .grid-search-results {
-  spacing: $base_padding * 6;
+  spacing: $base_padding*5;
 }
 
 // Search results with icons
@@ -54,6 +49,8 @@
 // search result provider
 .search-provider-icon {
   @extend %search_section_content_item;
+  &:ltr {margin-right: $base_margin;}
+  &:rtl {margin-left: $base_margin;}
 
   // content
   .list-search-provider-content {