[gtk/wip/baedert/for-master] gtkgstpaintable: Handle a NULL value




commit b74d3c22217be905f51445b49425e44cfd5b2f2a
Author: Timm Bäder <mail baedert org>
Date:   Wed Feb 16 10:01:13 2022 +0100

    gtkgstpaintable: Handle a NULL value
    
    gst_element_factory_make can return NULL.

 modules/media/gtkgstpaintable.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
---
diff --git a/modules/media/gtkgstpaintable.c b/modules/media/gtkgstpaintable.c
index aae52b03e5..0a4309b9d3 100644
--- a/modules/media/gtkgstpaintable.c
+++ b/modules/media/gtkgstpaintable.c
@@ -115,7 +115,7 @@ gtk_gst_paintable_video_renderer_create_video_sink (GstPlayerVideoRenderer *rend
                                                     GstPlayer              *player)
 {
   GtkGstPaintable *self = GTK_GST_PAINTABLE (renderer);
-  GstElement *sink, *glsinkbin;
+  GstElement *sink;
   GdkGLContext *ctx;
 
   sink = g_object_new (GTK_TYPE_GST_SINK,
@@ -128,7 +128,10 @@ gtk_gst_paintable_video_renderer_create_video_sink (GstPlayerVideoRenderer *rend
 
   if (self->context != NULL && ctx != NULL)
     {
-      glsinkbin = gst_element_factory_make ("glsinkbin", NULL);
+      GstElement *glsinkbin = gst_element_factory_make ("glsinkbin", NULL);
+
+      if (!glsinkbin)
+        return NULL;
 
       g_object_set (glsinkbin, "sink", sink, NULL);
       g_object_unref (ctx);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]