[gnome-control-center] keyboard: Allow input list rows to manage their own size
- From: Georges Basile Stavracas Neto <gbsneto src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-control-center] keyboard: Allow input list rows to manage their own size
- Date: Sun, 13 Feb 2022 13:41:33 +0000 (UTC)
commit 1a3971fdbefb4763a4df3c31852354ae743b65a2
Author: Christopher Davis <christopherdavis gnome org>
Date: Sat Feb 12 17:26:22 2022 -0800
keyboard: Allow input list rows to manage their own size
Using GtkSizeGroup causes weird jumping,
and size groups generally should not be used for
boxed list rows.
panels/keyboard/cc-input-list-box.c | 3 ---
panels/keyboard/cc-input-list-box.ui | 6 ------
2 files changed, 9 deletions(-)
---
diff --git a/panels/keyboard/cc-input-list-box.c b/panels/keyboard/cc-input-list-box.c
index c03a26d69..2d7aa581c 100644
--- a/panels/keyboard/cc-input-list-box.c
+++ b/panels/keyboard/cc-input-list-box.c
@@ -42,7 +42,6 @@ struct _CcInputListBox {
AdwBin parent_instance;
GtkListBoxRow *add_input_row;
- GtkSizeGroup *input_size_group;
GtkListBox *listbox;
GtkListBoxRow *no_inputs_row;
@@ -285,7 +284,6 @@ add_input_row (CcInputListBox *self, CcInputSource *source)
row = cc_input_row_new (source);
gtk_widget_show (GTK_WIDGET (row));
- gtk_size_group_add_widget (self->input_size_group, GTK_WIDGET (row));
g_signal_connect_object (row, "show-settings", G_CALLBACK (row_settings_cb), self, G_CONNECT_SWAPPED);
g_signal_connect_object (row, "show-layout", G_CALLBACK (row_layout_cb), self, G_CONNECT_SWAPPED);
g_signal_connect_object (row, "move-row", G_CALLBACK (row_moved_cb), self, G_CONNECT_SWAPPED);
@@ -733,7 +731,6 @@ cc_input_list_box_class_init (CcInputListBoxClass *klass)
gtk_widget_class_set_template_from_resource (widget_class,
"/org/gnome/control-center/keyboard/cc-input-list-box.ui");
gtk_widget_class_bind_template_child (widget_class, CcInputListBox, add_input_row);
- gtk_widget_class_bind_template_child (widget_class, CcInputListBox, input_size_group);
gtk_widget_class_bind_template_child (widget_class, CcInputListBox, listbox);
gtk_widget_class_bind_template_child (widget_class, CcInputListBox, no_inputs_row);
diff --git a/panels/keyboard/cc-input-list-box.ui b/panels/keyboard/cc-input-list-box.ui
index 16e014147..e50bfde54 100644
--- a/panels/keyboard/cc-input-list-box.ui
+++ b/panels/keyboard/cc-input-list-box.ui
@@ -43,10 +43,4 @@
</child>
</template>
- <object class="GtkSizeGroup" id="input_size_group">
- <property name="mode">vertical</property>
- <widgets>
- <widget name="no_inputs_row"/>
- </widgets>
- </object>
</interface>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]