[gimp-help] filter: fix #246 swap erode/dilate descriptions

From: Jacob Boerema <jboerema src gnome org>
To: commits-list gnome org
Cc:
Subject: [gimp-help] filter: fix #246 swap erode/dilate descriptions
Date: Mon, 7 Feb 2022 17:04:38 +0000 (UTC)
commit e23fbd61886ffb5e2db7240d028481f4407e2653
Author: Anders Jonsson <anders jonsson norsjovallen se>
Date:   Thu Feb 3 01:24:58 2022 +0100

    filter: fix #246 swap erode/dilate descriptions
    
    Erode and dilate swapped meanings in 5e78e9a2,
    but gimp-help was never updated.

 .../{erode-noise.png => dilate-noise-removal.png}  | Bin
 .../examples/{dilate-text.png => erode-text.png}   | Bin
 images/C/filters/examples/generic-taj-dilate.jpg   | Bin 26549 -> 26589 bytes
 images/C/filters/examples/generic-taj-erode.jpg    | Bin 26589 -> 26549 bytes
 .../{dilate-milord.png => erode-milord.png}        | Bin
 .../generic/{dilate-pixel.png => erode-pixel.png}  | Bin
 .../generic/{dilate-zone.png => erode-zone.png}    | Bin
 src/filters/generic/dilate.xml                     |  68 +++++--------------
 src/filters/generic/erode.xml                      |  74 +++++++++++++++------
 9 files changed, 73 insertions(+), 69 deletions(-)
---
diff --git a/images/C/filters/examples/erode-noise.png b/images/C/filters/examples/dilate-noise-removal.png
similarity index 100%
rename from images/C/filters/examples/erode-noise.png
rename to images/C/filters/examples/dilate-noise-removal.png
diff --git a/images/C/filters/examples/dilate-text.png b/images/C/filters/examples/erode-text.png
similarity index 100%
rename from images/C/filters/examples/dilate-text.png
rename to images/C/filters/examples/erode-text.png
diff --git a/images/C/filters/examples/generic-taj-dilate.jpg 
b/images/C/filters/examples/generic-taj-dilate.jpg
index be0428fb6..c98cebf22 100644
Binary files a/images/C/filters/examples/generic-taj-dilate.jpg and 
b/images/C/filters/examples/generic-taj-dilate.jpg differ
diff --git a/images/C/filters/examples/generic-taj-erode.jpg b/images/C/filters/examples/generic-taj-erode.jpg
index c98cebf22..be0428fb6 100644
Binary files a/images/C/filters/examples/generic-taj-erode.jpg and 
b/images/C/filters/examples/generic-taj-erode.jpg differ
diff --git a/images/C/filters/generic/dilate-milord.png b/images/C/filters/generic/erode-milord.png
similarity index 100%
rename from images/C/filters/generic/dilate-milord.png
rename to images/C/filters/generic/erode-milord.png
diff --git a/images/C/filters/generic/dilate-pixel.png b/images/C/filters/generic/erode-pixel.png
similarity index 100%
rename from images/C/filters/generic/dilate-pixel.png
rename to images/C/filters/generic/erode-pixel.png
diff --git a/images/C/filters/generic/dilate-zone.png b/images/C/filters/generic/erode-zone.png
similarity index 100%
rename from images/C/filters/generic/dilate-zone.png
rename to images/C/filters/generic/erode-zone.png
diff --git a/src/filters/generic/dilate.xml b/src/filters/generic/dilate.xml
index 9dacf108f..49f375179 100644
--- a/src/filters/generic/dilate.xml
+++ b/src/filters/generic/dilate.xml
@@ -11,7 +11,6 @@
 -->
 <sect2 id="plug-in-dilate">
   <title>Dilate</title>
-
   <indexterm>
     <primary>Filters</primary>
     <secondary>Generic</secondary>
@@ -24,7 +23,7 @@
   <sect3>
     <title>Overview</title>
     <figure>
-      <title>Applying example for the Dilate filter</title>
+      <title>Dilate</title>
       <mediaobject>
         <imageobject>
           <imagedata format="JPG"
@@ -45,53 +44,31 @@
       </mediaobject>
     </figure>
     <para>
-      This filter widens and enhances dark areas of the active layer or
+      This filter widens and enhances bright areas of the active layer or
       selection.
     </para>
     <para>
       For every image pixel, it brings the pixel Value (luminosity) into line
-      with the lowest Value (the darkest) of the 8 neighbouring pixels (3x3
-      matrix). So, a dark pixel is added around dark areas. An isolated pixel
-      on a brighter background will be changed to a big <quote>pixel</quote>,
-      composed of 9 pixels, and that will create some noise in the image.
-    </para>
-    <mediaobject>
-      <imageobject>
-        <imagedata format="PNG"
-          fileref="images/filters/generic/dilate-pixel.png"/>
-      </imageobject>
-    </mediaobject>
-    <para>
-      In this image, the studied pixel has a red border and the studied
-      matrix has a green border. I hope you have understood how to go on
-      with the process and get a 3x3 pixel block: when the <quote>I</quote>
-      pixel is inside the green border, the studied pixel turns to black.
-    </para>
-    <para>
-      A larger dark area will dilate by one pixel in all directions:
-    </para>
-    <mediaobject>
-      <imageobject>
-        <imagedata format="PNG"
-          fileref="images/filters/generic/dilate-zone.png"/>
-      </imageobject>
-    </mediaobject>
-    <para>
-      The filter was applied 3 times.
+      with the upper value (the brightest) of the 8 neighbouring pixels (3x3
+      matrix). So, a bright pixel is added around bright areas. An isolated
+      pixel on a brighter background will be deleted. A larger bright area
+      will dilate by one pixel in all directions.
     </para>
     <para>
-      On more complex images, dark areas are widened and enhanced the same,
-      and somewhat pixellated. Here, the filter was applied 3 times:
+      On complex images, bright areas are widened and enhanced the same, and
+      somewhat pixellated.
     </para>
-    <mediaobject>
-      <imageobject>
-        <imagedata format="PNG"
-          fileref="images/filters/generic/dilate-milord.png"/>
-      </imageobject>
-    </mediaobject>
     <para>
-      Of course, if background is darker than foreground, it will cover the
-      whole image.
+      On a solid background, this filter can delete noise:
+      <figure>
+        <title><quote>Dilate</quote> example</title>
+        <mediaobject>
+          <imageobject>
+            <imagedata format="PNG"
+              fileref="images/filters/examples/dilate-noise-removal.png"/>
+          </imageobject>
+        </mediaobject>
+      </figure>
     </para>
   </sect3>
 
@@ -109,15 +86,6 @@
 
   <sect3>
     <title>Examples</title>
-    <figure>
-      <title>Dilate text</title>
-      <mediaobject>
-        <imageobject>
-          <imagedata format="PNG"
-            fileref="images/filters/examples/dilate-text.png"/>
-        </imageobject>
-      </mediaobject>
-    </figure>
     <figure>
       <title>Dilate neon effect</title>
       <mediaobject>
diff --git a/src/filters/generic/erode.xml b/src/filters/generic/erode.xml
index 190bfc1c0..ee1e004e5 100644
--- a/src/filters/generic/erode.xml
+++ b/src/filters/generic/erode.xml
@@ -12,6 +12,7 @@
 -->
 <sect2 id="plug-in-erode">
   <title>Erode</title>
+
   <indexterm>
     <primary>Filters</primary>
     <secondary>Generic</secondary>
@@ -24,7 +25,7 @@
   <sect3>
     <title>Overview</title>
     <figure>
-      <title>Erode noise</title>
+      <title>Applying example for the Erode filter</title>
       <mediaobject>
         <imageobject>
           <imagedata format="JPG"
@@ -40,36 +41,58 @@
             fileref="images/filters/examples/generic-taj-erode.jpg"/>
         </imageobject>
         <caption>
-          <para>Filter <quote>Erode noise</quote> applied</para>
+          <para>Filter <quote>Erode</quote> applied</para>
         </caption>
       </mediaobject>
     </figure>
     <para>
-      This filter widens and enhances bright areas of the active layer or
+      This filter widens and enhances dark areas of the active layer or
       selection.
     </para>
     <para>
       For every image pixel, it brings the pixel Value (luminosity) into line
-      with the upper value (the brightest) of the 8 neighbouring pixels (3x3
-      matrix). So, a bright pixel is added around bright areas. An isolated
-      pixel on a brighter background will be deleted. A larger bright area
-      will dilate by one pixel in all directions.
+      with the lowest Value (the darkest) of the 8 neighbouring pixels (3x3
+      matrix). So, a dark pixel is added around dark areas. An isolated pixel
+      on a brighter background will be changed to a big <quote>pixel</quote>,
+      composed of 9 pixels, and that will create some noise in the image.
+    </para>
+    <mediaobject>
+      <imageobject>
+        <imagedata format="PNG"
+          fileref="images/filters/generic/erode-pixel.png"/>
+      </imageobject>
+    </mediaobject>
+    <para>
+      In this image, the studied pixel has a red border and the studied
+      matrix has a green border. I hope you have understood how to go on
+      with the process and get a 3x3 pixel block: when the <quote>I</quote>
+      pixel is inside the green border, the studied pixel turns to black.
+    </para>
+    <para>
+      A larger dark area will expand by one pixel in all directions:
+    </para>
+    <mediaobject>
+      <imageobject>
+        <imagedata format="PNG"
+          fileref="images/filters/generic/erode-zone.png"/>
+      </imageobject>
+    </mediaobject>
+    <para>
+      The filter was applied 3 times.
     </para>
     <para>
-      On complex images, bright areas are widened and enhanced the same, and
-      somewhat pixellated.
+      On more complex images, dark areas are widened and enhanced the same,
+      and somewhat pixellated. Here, the filter was applied 3 times:
     </para>
+    <mediaobject>
+      <imageobject>
+        <imagedata format="PNG"
+          fileref="images/filters/generic/erode-milord.png"/>
+      </imageobject>
+    </mediaobject>
     <para>
-      On a solid background, this filter can delete noise:
-      <figure>
-        <title><quote>Erode noise</quote> example</title>
-        <mediaobject>
-          <imageobject>
-            <imagedata format="PNG"
-              fileref="images/filters/examples/erode-noise.png"/>
-          </imageobject>
-        </mediaobject>
-      </figure>
+      Of course, if background is darker than foreground, it will cover the
+      whole image.
     </para>
   </sect3>
 
@@ -84,4 +107,17 @@
       </menuchoice>.
     </para>
   </sect3>
+
+  <sect3>
+    <title>Examples</title>
+    <figure>
+      <title>Erode text</title>
+      <mediaobject>
+        <imageobject>
+          <imagedata format="PNG"
+            fileref="images/filters/examples/erode-text.png"/>
+        </imageobject>
+      </mediaobject>
+    </figure>
+  </sect3>
 </sect2>
[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]