[gnome-online-accounts/wip/make-the-web-view-bigger] webview: Increase fixed size by 100×100px




commit 1c2a69b05deb3e6fe7ff9c8647e4e0e88532d796
Author: Will Thompson <will willthompson co uk>
Date:   Mon Feb 7 10:34:19 2022 +0000

    webview: Increase fixed size by 100×100px
    
    At the previous fixed size of 400×500px, the "Next" button on the first
    page of the Google login flow is not visible. It also feels,
    subjectively, a bit cramped.
    
    Increasing the fixed size by 100px in each axis makes the "Next" button
    visible, is smaller than the default size of Initial Setup and Settings
    (the parent application for the dialog this view is embedded in), and
    also falls within the HIG-specified smallest display size of 1024×600.
    (The existing natural_size constants already exceed the HIG-specified
    minimum phone size of 360×294.)
    
    https://developer.gnome.org/hig/guidelines/adaptive.html?highlight=size#small-size-handling

 src/goabackend/goawebview.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/goabackend/goawebview.c b/src/goabackend/goawebview.c
index 2438e0cd..cdd94ec3 100644
--- a/src/goabackend/goawebview.c
+++ b/src/goabackend/goawebview.c
@@ -257,7 +257,7 @@ goa_web_view_get_preferred_height (GtkWidget *widget, gint *minimum_size, gint *
     *minimum_size = 200;
 
   if (natural_size != NULL)
-    *natural_size = 400;
+    *natural_size = 500;
 }
 
 static void
@@ -267,7 +267,7 @@ goa_web_view_get_preferred_width (GtkWidget *widget, gint *minimum_size, gint *n
     *minimum_size = 300;
 
   if (natural_size != NULL)
-    *natural_size = 500;
+    *natural_size = 600;
 }
 
 static GtkSizeRequestMode


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]