[gimp] Revert "app: check selected items changed before running "select-items"."



commit 748dc77bb58c09a9b98e56365e019bfec7d598ad
Author: Jehan <jehan girinstud io>
Date:   Wed Feb 2 17:56:49 2022 +0100

    Revert "app: check selected items changed before running "select-items"."
    
    This reverts commit ca3c4803146cb8fac1dfbb5ecd241035f54372a8.
    
    The fix was wrong and was creating other issues such as #7655. We must
    always emit this signal.

 app/widgets/gimpcontainerview.c | 39 ++-------------------------------------
 1 file changed, 2 insertions(+), 37 deletions(-)
---
diff --git a/app/widgets/gimpcontainerview.c b/app/widgets/gimpcontainerview.c
index fc22d9d154..0147040d23 100644
--- a/app/widgets/gimpcontainerview.c
+++ b/app/widgets/gimpcontainerview.c
@@ -147,9 +147,6 @@ static void  gimp_container_view_button_viewable_dropped (GtkWidget    *widget,
                                                           GimpViewable *viewable,
                                                           gpointer      data);
 
-static gboolean gimp_container_view_are_selected_items (GimpContainerView    *view,
-                                                        GList                *items);
-
 
 G_DEFINE_INTERFACE (GimpContainerView, gimp_container_view, GTK_TYPE_WIDGET)
 
@@ -519,11 +516,8 @@ gimp_container_view_select_items (GimpContainerView *view,
   if (gimp_container_frozen (private->container))
     return TRUE;
 
-  if (gimp_container_view_are_selected_items (view, viewables))
-    success = TRUE;
-  else
-    g_signal_emit (view, view_signals[SELECT_ITEMS], 0,
-                   viewables, NULL, &success);
+  g_signal_emit (view, view_signals[SELECT_ITEMS], 0,
+                 viewables, NULL, &success);
 
   return success;
 }
@@ -1415,32 +1409,3 @@ gimp_container_view_button_viewable_dropped (GtkWidget    *widget,
       gtk_button_clicked (GTK_BUTTON (widget));
     }
 }
-
-static gboolean
-gimp_container_view_are_selected_items (GimpContainerView *view,
-                                        GList             *items)
-{
-  GList    *selected;
-  gboolean  identical = FALSE;
-
-  gimp_container_view_get_selected (view, &selected, NULL);
-
-  if (g_list_length (items) == g_list_length (selected))
-    {
-      GList *iter;
-
-      identical = TRUE;
-      for (iter = items; iter; iter = iter->next)
-        {
-          if (g_list_find (selected, iter->data) == NULL)
-            {
-              identical = FALSE;
-              break;
-            }
-        }
-    }
-
-  g_list_free (selected);
-
-  return identical;
-}


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]