[gnome-software: 1/2] fwupd: Do only refresh for KIND_DOWNLOAD repositories
- From: Richard Hughes <rhughes src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software: 1/2] fwupd: Do only refresh for KIND_DOWNLOAD repositories
- Date: Wed, 2 Feb 2022 13:26:06 +0000 (UTC)
commit 933e1d69d98c2c2fef6dbb926598520ca7105c7b
Author: Pablo Correa Gómez <ablocorrea hotmail com>
Date: Tue Feb 1 23:57:25 2022 +0100
fwupd: Do only refresh for KIND_DOWNLOAD repositories
FWUPD_REMOTE_KIND_DIRECTORY was missing in the comparison and caused
a crash when a repository of that kind was enabled. As suggested by
Richard Hughes, it is safer to not download repositories which
are of KIND_DOWNLOAD than to blacklist all other possible kinds.
plugins/fwupd/gs-plugin-fwupd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/plugins/fwupd/gs-plugin-fwupd.c b/plugins/fwupd/gs-plugin-fwupd.c
index 5cab8357d..db2d3b62d 100644
--- a/plugins/fwupd/gs-plugin-fwupd.c
+++ b/plugins/fwupd/gs-plugin-fwupd.c
@@ -748,7 +748,7 @@ gs_plugin_refresh (GsPlugin *plugin,
FwupdRemote *remote = g_ptr_array_index (remotes, i);
if (!fwupd_remote_get_enabled (remote))
continue;
- if (fwupd_remote_get_kind (remote) == FWUPD_REMOTE_KIND_LOCAL)
+ if (fwupd_remote_get_kind (remote) != FWUPD_REMOTE_KIND_DOWNLOAD)
continue;
if (!gs_plugin_fwupd_refresh_remote (self, remote, cache_age,
cancellable, error))
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]