[gnome-shell/wip/carlosg/grab-helper-captured-events: 4/4] popupMenu: Ensure to let focus manager handle key events
- From: Marge Bot <marge-bot src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/wip/carlosg/grab-helper-captured-events: 4/4] popupMenu: Ensure to let focus manager handle key events
- Date: Tue, 1 Feb 2022 13:50:02 +0000 (UTC)
commit 4eb1440d88db84c54fbbcffb9f0b17cbca280d93
Author: Carlos Garnacho <carlosg gnome org>
Date: Tue Feb 1 14:33:03 2022 +0100
popupMenu: Ensure to let focus manager handle key events
Since the grab no longer lets events bubble up to the stage unstopped,
we should be forwarding the key events that bubbled up to the dialog
to maybe cycle focus.
Fixes broken keyboard navigation in several context menus around the
shell, other than the panel ones.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2140>
js/ui/popupMenu.js | 3 +++
1 file changed, 3 insertions(+)
---
diff --git a/js/ui/popupMenu.js b/js/ui/popupMenu.js
index a0c00067d1..b464673626 100644
--- a/js/ui/popupMenu.js
+++ b/js/ui/popupMenu.js
@@ -154,6 +154,9 @@ var PopupBaseMenuItem = GObject.registerClass({
}
vfunc_key_press_event(keyEvent) {
+ if (global.focus_manager.navigate_from_event(Clutter.get_current_event()))
+ return Clutter.EVENT_STOP;
+
if (!this._activatable)
return super.vfunc_key_press_event(keyEvent);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]