[gnome-software/1878-failure-to-get-updates-in-one-plugin-skips-other-plugins] flatpak: Ignore errors when refreshing meta data

[Milan Crha <mcrha src gnome org>]

commit 27bda8e6549341c05f791efb7d049f5fb674c929
Author: Milan Crha <mcrha redhat com>
Date:   Fri Aug 26 15:24:36 2022 +0200

    flatpak: Ignore errors when refreshing meta data
    
    Let all the installations be refreshed, even when one has temporary
    or permanent failure.
    
    Helps https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1878

 plugins/flatpak/gs-plugin-flatpak.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
---
diff --git a/plugins/flatpak/gs-plugin-flatpak.c b/plugins/flatpak/gs-plugin-flatpak.c
index f5bc68569..8510627fc 100644
--- a/plugins/flatpak/gs-plugin-flatpak.c
+++ b/plugins/flatpak/gs-plugin-flatpak.c
@@ -433,17 +433,15 @@ refresh_metadata_thread_cb (GTask        *task,
        GsPluginFlatpak *self = GS_PLUGIN_FLATPAK (source_object);
        GsPluginRefreshMetadataData *data = task_data;
        gboolean interactive = (data->flags & GS_PLUGIN_REFRESH_METADATA_FLAGS_INTERACTIVE);
-       g_autoptr(GError) local_error = NULL;
 
        assert_in_worker (self);
 
        for (guint i = 0; i < self->installations->len; i++) {
+               g_autoptr(GError) local_error = NULL;
                GsFlatpak *flatpak = g_ptr_array_index (self->installations, i);
 
-               if (!gs_flatpak_refresh (flatpak, data->cache_age_secs, interactive, cancellable, 
&local_error)) {
-                       g_task_return_error (task, g_steal_pointer (&local_error));
-                       return;
-               }
+               if (!gs_flatpak_refresh (flatpak, data->cache_age_secs, interactive, cancellable, 
&local_error))
+                       g_debug ("Failed to refresh metadata for '%s': %s", gs_flatpak_get_id (flatpak), 
local_error->message);
        }
 
        g_task_return_boolean (task, TRUE);