[geary/gnumdk/autoconfig: 2/2] treewide: Removed unused Yahoo imap engine

[Cédric Bellegarde <cbellegarde src gnome org>]

commit 836de3f7a3b6d8cdad8506609077d4ca301f9109
Author: Cédric Bellegarde <cedric.bellegarde@ædishatz.org>
Date:   Thu Aug 25 23:16:22 2022 +0200

    treewide: Removed unused Yahoo imap engine
    
    This is not useful now we have autoconfig support

 src/client/accounts/accounts-editor-list-pane.vala |  4 --
 src/client/accounts/accounts-editor-row.vala       |  4 --
 .../accounts/accounts-editor-servers-pane.vala     |  1 -
 src/engine/api/geary-engine.vala                   | 11 +---
 src/engine/api/geary-service-provider.vala         |  7 ---
 .../yahoo/imap-engine-yahoo-account.vala           | 60 ----------------------
 .../yahoo/imap-engine-yahoo-folder.vala            | 13 -----
 src/engine/meson.build                             |  2 -
 .../engine/api/geary-account-information-test.vala |  8 ---
 9 files changed, 1 insertion(+), 109 deletions(-)
---
diff --git a/src/client/accounts/accounts-editor-list-pane.vala 
b/src/client/accounts/accounts-editor-list-pane.vala
index 2f0918d83..e7d718430 100644
--- a/src/client/accounts/accounts-editor-list-pane.vala
+++ b/src/client/accounts/accounts-editor-list-pane.vala
@@ -329,10 +329,6 @@ private class Accounts.AccountListRow : AccountRow<EditorListPane,Gtk.Grid> {
             details = _("Outlook.com");
             break;
 
-        case Geary.ServiceProvider.YAHOO:
-            details = _("Yahoo");
-            break;
-
         case Geary.ServiceProvider.OTHER:
             // no-op: Use the generated label
             break;
diff --git a/src/client/accounts/accounts-editor-row.vala b/src/client/accounts/accounts-editor-row.vala
index cca825acc..2f8084667 100644
--- a/src/client/accounts/accounts-editor-row.vala
+++ b/src/client/accounts/accounts-editor-row.vala
@@ -283,10 +283,6 @@ internal class Accounts.ServiceProviderRow<PaneType> :
             label = _("Outlook.com");
             break;
 
-        case Geary.ServiceProvider.YAHOO:
-            label = _("Yahoo");
-            break;
-
         case Geary.ServiceProvider.OTHER:
             label = other_type_label;
             break;
diff --git a/src/client/accounts/accounts-editor-servers-pane.vala 
b/src/client/accounts/accounts-editor-servers-pane.vala
index 558bc9bcc..8bd9bde1f 100644
--- a/src/client/accounts/accounts-editor-servers-pane.vala
+++ b/src/client/accounts/accounts-editor-servers-pane.vala
@@ -115,7 +115,6 @@ internal class Accounts.EditorServersPane :
             this.account, this.commands, this.op_cancellable
         );
         switch (account.service_provider) {
-        case YAHOO:
         case OTHER:
             add_row(this.details_list, this.save_sent);
             break;
diff --git a/src/engine/api/geary-engine.vala b/src/engine/api/geary-engine.vala
index 69089c08a..ab8b40d71 100644
--- a/src/engine/api/geary-engine.vala
+++ b/src/engine/api/geary-engine.vala
@@ -218,26 +218,17 @@ public class Geary.Engine : BaseObject {
                 );
             break;
 
-            case ServiceProvider.YAHOO:
-                account = new ImapEngine.YahooAccount(
-                    config, local, incoming_remote, outgoing_remote
-                );
-            break;
-
             case ServiceProvider.OUTLOOK:
                 account = new ImapEngine.OutlookAccount(
                     config, local, incoming_remote, outgoing_remote
                 );
             break;
 
-            case ServiceProvider.OTHER:
+            default:
                 account = new ImapEngine.OtherAccount(
                     config, local, incoming_remote, outgoing_remote
                 );
             break;
-
-            default:
-                assert_not_reached();
         }
 
         config.notify["ordinal"].connect(on_account_ordinal_changed);
diff --git a/src/engine/api/geary-service-provider.vala b/src/engine/api/geary-service-provider.vala
index 517bc3a4b..c61cba421 100644
--- a/src/engine/api/geary-service-provider.vala
+++ b/src/engine/api/geary-service-provider.vala
@@ -12,7 +12,6 @@
 
 public enum Geary.ServiceProvider {
     GMAIL,
-    YAHOO,
     OUTLOOK,
     OTHER;
 
@@ -34,9 +33,6 @@ public enum Geary.ServiceProvider {
         case GMAIL:
             ImapEngine.GmailAccount.setup_account(service);
             break;
-        case YAHOO:
-            ImapEngine.YahooAccount.setup_account(service);
-            break;
         case OUTLOOK:
             ImapEngine.OutlookAccount.setup_account(service);
             break;
@@ -51,9 +47,6 @@ public enum Geary.ServiceProvider {
         case GMAIL:
             ImapEngine.GmailAccount.setup_service(service);
             break;
-        case YAHOO:
-            ImapEngine.YahooAccount.setup_service(service);
-            break;
         case OUTLOOK:
             ImapEngine.OutlookAccount.setup_service(service);
             break;
diff --git a/src/engine/meson.build b/src/engine/meson.build
index 7e4e6381f..5efe081f4 100644
--- a/src/engine/meson.build
+++ b/src/engine/meson.build
@@ -222,8 +222,6 @@ engine_vala_sources = files(
   'imap-engine/replay-ops/imap-engine-replay-update.vala',
   'imap-engine/replay-ops/imap-engine-server-search-email.vala',
   'imap-engine/replay-ops/imap-engine-user-close.vala',
-  'imap-engine/yahoo/imap-engine-yahoo-account.vala',
-  'imap-engine/yahoo/imap-engine-yahoo-folder.vala',
 
   'memory/memory-buffer.vala',
   'memory/memory-byte-buffer.vala',
diff --git a/test/engine/api/geary-account-information-test.vala 
b/test/engine/api/geary-account-information-test.vala
index 447902738..aec0a6a71 100644
--- a/test/engine/api/geary-account-information-test.vala
+++ b/test/engine/api/geary-account-information-test.vala
@@ -41,14 +41,6 @@ class Geary.AccountInformationTest : TestCase {
                 new RFC822.MailboxAddress(null, "test1 example com")
             ).save_sent
         );
-        assert_true(
-            new AccountInformation(
-                "test",
-                ServiceProvider.YAHOO,
-                new Mock.CredentialsMediator(),
-                new RFC822.MailboxAddress(null, "test1 example com")
-            ).save_sent
-        );
     }
 
     public void test_sender_mailboxes() throws GLib.Error {