[gnome-shell] status/network: Use NM connectivity check URI for Portal Helper
- From: Marge Bot <marge-bot src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] status/network: Use NM connectivity check URI for Portal Helper
- Date: Thu, 18 Aug 2022 08:04:18 +0000 (UTC)
commit 2d6b21357db1196afe70d2c89816c989c52a2069
Author: Clerie Riese <git clerie de>
Date: Sun Mar 6 16:02:52 2022 +0100
status/network: Use NM connectivity check URI for Portal Helper
NetworkManager can check if a network interface has "internet access" by
invoking a HTTP request.
The URI used for connectivity checking in NetworkManager can be configured
manually in NetworkManager.conf:
[connectivity]
uri=http://portal-check.exmaple.com/nm-check.txt
Portal Helper provides an argument to pass the URI that should be opened.
If this argument is empty it uses http://nmcheck.gnome.org as a fallback.
Pass the URI configured in NetworkManager to Portal Helper instead of
an empty string.
Fixes #1313
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2228>
js/ui/status/network.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/js/ui/status/network.js b/js/ui/status/network.js
index aef2373fb8..7a191e03bd 100644
--- a/js/ui/status/network.js
+++ b/js/ui/status/network.js
@@ -2060,7 +2060,7 @@ class Indicator extends SystemIndicator {
}
}
- this._portalHelperProxy?.AuthenticateAsync(path, '', timestamp).catch(logError);
+ this._portalHelperProxy?.AuthenticateAsync(path, this._client.connectivity_check_uri,
timestamp).catch(logError);
this._connectivityQueue.add(path);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]