[gnome-initial-setup] Remove short circuit from should_skip_page to fix page skipping



commit 981ec92d3c830b0cc3d808fb1d6c438e506cba7d
Author: Adam Williamson <awilliam redhat com>
Date:   Fri Aug 12 22:44:33 2022 -0700

    Remove short circuit from should_skip_page to fix page skipping
    
    For some reason, the GTK4 port (MR !134) introduced this short-
    circuit to `should_skip_page` which means it will never return
    TRUE and page skipping will never work. We (Fedora) rather want
    page skipping to work so, er, let's put it back!
    
    Signed-off-by: Adam Williamson <awilliam redhat com>
    Part-of: <https://gitlab.gnome.org/GNOME/gnome-initial-setup/-/merge_requests/156>

 gnome-initial-setup/gnome-initial-setup.c | 2 --
 1 file changed, 2 deletions(-)
---
diff --git a/gnome-initial-setup/gnome-initial-setup.c b/gnome-initial-setup/gnome-initial-setup.c
index 81df2499..113ded36 100644
--- a/gnome-initial-setup/gnome-initial-setup.c
+++ b/gnome-initial-setup/gnome-initial-setup.c
@@ -94,8 +94,6 @@ should_skip_page (const gchar  *page_id,
   if (strcmp (page_id, "welcome") == 0)
     return !should_skip_page ("language", skip_pages);
 
-  return FALSE;
-
   /* check through our skip pages list for pages we don't want */
   if (skip_pages) {
     while (skip_pages[i]) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]