[gnome-shell/wip/carlosg/osk-updates: 24/33] keyboard: Let the OSK take 1/4th of height in portrait mode
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/wip/carlosg/osk-updates: 24/33] keyboard: Let the OSK take 1/4th of height in portrait mode
- Date: Wed, 10 Aug 2022 17:11:30 +0000 (UTC)
commit b18ab0086e522cae9855abab8add6bfb52152dd5
Author: Carlos Garnacho <carlosg gnome org>
Date: Wed Jun 1 17:39:57 2022 +0200
keyboard: Let the OSK take 1/4th of height in portrait mode
And let the keys shrink horizontally to cover the full area.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2278>
js/ui/keyboard.js | 22 ++++------------------
1 file changed, 4 insertions(+), 18 deletions(-)
---
diff --git a/js/ui/keyboard.js b/js/ui/keyboard.js
index 9811acd454..840779e800 100644
--- a/js/ui/keyboard.js
+++ b/js/ui/keyboard.js
@@ -68,10 +68,6 @@ class AspectContainer extends St.Widget {
box.x1 += Math.floor(diff / 2);
box.x2 -= Math.ceil(diff / 2);
- } else {
- /* Restrict vertically, align to bottom */
- let height = box.get_width() / this._ratio;
- box.y1 = box.y2 - Math.floor(height);
}
}
@@ -1779,22 +1775,12 @@ var Keyboard = GObject.registerClass({
if (!monitor)
return;
- let maxHeight = monitor.height / 3;
this.width = monitor.width;
- if (monitor.width > monitor.height) {
- this.height = maxHeight;
- } else {
- /* In portrait mode, lack of horizontal space means we won't be
- * able to make the OSK that big while keeping size ratio, so
- * we allow the OSK being smaller than 1/3rd of the monitor height
- * there.
- */
- this.height = -1;
- const forWidth = this.get_theme_node().adjust_for_width(monitor.width);
- const [, natHeight] = this.get_preferred_height(forWidth);
- this.height = Math.min(maxHeight, natHeight);
- }
+ if (monitor.width > monitor.height)
+ this.height = monitor.height / 3;
+ else
+ this.height = monitor.height / 4;
}
_updateKeys() {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]