[gjs/mozjs102: 42/62] js: Use length overload of JS::NewArrayObject()
- From: Philip Chimento <pchimento src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gjs/mozjs102: 42/62] js: Use length overload of JS::NewArrayObject()
- Date: Sun, 7 Aug 2022 17:53:00 +0000 (UTC)
commit a987fee778641e1cbac1e02112065fb04a3dbad8
Author: Evan Welsh <contact evanwelsh com>
Date: Fri Jul 22 10:40:34 2022 -0700
js: Use length overload of JS::NewArrayObject()
It's not necessary to use JS::HandleValueArray::empty() here, since we
can just create an empty array of the proper length using the overload
that lets you specify an integer length.
modules/cairo-context.cpp | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
---
diff --git a/modules/cairo-context.cpp b/modules/cairo-context.cpp
index 463e06215..e321a6f26 100644
--- a/modules/cairo-context.cpp
+++ b/modules/cairo-context.cpp
@@ -20,7 +20,6 @@
#include <js/TypeDecls.h>
#include <js/Utility.h> // for UniqueChars
#include <js/Value.h>
-#include <js/ValueArray.h>
#include <jsapi.h> // for JS_SetElement
#include "gi/arg-inl.h"
@@ -86,9 +85,7 @@ _GJS_CAIRO_CONTEXT_DEFINE_FUNC_END
return false; \
cfunc(cr, &arg1, &arg2); \
if (cairo_status(cr) == CAIRO_STATUS_SUCCESS) { \
- JS::RootedObject array( \
- context, \
- JS::NewArrayObject(context, JS::HandleValueArray::empty())); \
+ JS::RootedObject array(context, JS::NewArrayObject(context, 2)); \
if (!array) \
return false; \
JS::RootedValue r(context, JS::NumberValue(arg1)); \
@@ -107,9 +104,7 @@ _GJS_CAIRO_CONTEXT_DEFINE_FUNC_END
_GJS_CAIRO_CONTEXT_CHECK_NO_ARGS(method) \
cfunc(cr, &arg1, &arg2); \
if (cairo_status(cr) == CAIRO_STATUS_SUCCESS) { \
- JS::RootedObject array( \
- context, \
- JS::NewArrayObject(context, JS::HandleValueArray::empty())); \
+ JS::RootedObject array(context, JS::NewArrayObject(context, 2)); \
if (!array) \
return false; \
JS::RootedValue r(context, JS::NumberValue(arg1)); \
@@ -128,9 +123,7 @@ _GJS_CAIRO_CONTEXT_DEFINE_FUNC_END
_GJS_CAIRO_CONTEXT_CHECK_NO_ARGS(method) \
cfunc(cr, &arg1, &arg2, &arg3, &arg4); \
{ \
- JS::RootedObject array( \
- context, \
- JS::NewArrayObject(context, JS::HandleValueArray::empty())); \
+ JS::RootedObject array(context, JS::NewArrayObject(context, 4)); \
if (!array) \
return false; \
JS::RootedValue r(context, JS::NumberValue(arg1)); \
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]