[gnome-software: 1/2] ui: Don’t fade in spinners which are next to a status label




commit 6f877bd250ed98dfc844d2e807219c4e1a917a53
Author: Philip Withnall <pwithnall endlessos org>
Date:   Mon Jul 25 19:19:23 2022 +0200

    ui: Don’t fade in spinners which are next to a status label
    
    If these spinners fade in, the labels are visible for a few seconds
    without a spinner. During that time, it looks like they’re layed out in
    the wrong place.
    
    Fading in the spinner was (I think) an attempt to reduce glitchiness of
    briefly showing a spinner for a fraction of a second before the content
    loads. However, if a label is being shown as well then there’s already
    glitchiness so the fading doesn’t achieve anything.
    
    Signed-off-by: Philip Withnall <pwithnall endlessos org>
    
    See: #1429

 src/gs-details-page.ui | 3 ---
 src/gs-repos-dialog.ui | 3 ---
 src/gs-updates-page.ui | 1 -
 3 files changed, 7 deletions(-)
---
diff --git a/src/gs-details-page.ui b/src/gs-details-page.ui
index 72ea54334..ad5ff8c33 100644
--- a/src/gs-details-page.ui
+++ b/src/gs-details-page.ui
@@ -31,9 +31,6 @@
                     <property name="valign">center</property>
                     <property name="hexpand">True</property>
                     <property name="vexpand">True</property>
-                    <style>
-                      <class name="fade-in"/>
-                    </style>
                   </object>
                 </child>
                 <child>
diff --git a/src/gs-repos-dialog.ui b/src/gs-repos-dialog.ui
index 9183f5b7c..c28fca0f3 100644
--- a/src/gs-repos-dialog.ui
+++ b/src/gs-repos-dialog.ui
@@ -39,9 +39,6 @@
                     <property name="valign">center</property>
                     <property name="hexpand">True</property>
                     <property name="vexpand">True</property>
-                    <style>
-                      <class name="fade-in"/>
-                    </style>
                   </object>
                 </property>
               </object>
diff --git a/src/gs-updates-page.ui b/src/gs-updates-page.ui
index dafc72465..654cbdb3b 100644
--- a/src/gs-updates-page.ui
+++ b/src/gs-updates-page.ui
@@ -69,7 +69,6 @@
                                 <property name="vexpand">True</property>
                                 <style>
                                   <class name="icon"/>
-                                  <class name="fade-in"/>
                                 </style>
                               </object>
                             </child>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]