[nautilus/wip/antoniof/three-menus-no-more: 3/7] toolbar: Move "Visible Columns" menu item to folder menu




commit 08a9723ce5cfe79e6cdad7fd36a7e9a10a712471
Author: António Fernandes <antoniof gnome org>
Date:   Sun Jul 31 21:52:07 2022 +0100

    toolbar: Move "Visible Columns" menu item to folder menu
    
    It would be nice to use gtk_column_view_column_set_header_menu(),
    but unfortunately our GtkGestureClick for background context menu
    overrules it. Also, it would be bad for accessibility because
    there is no way to get keyboard focus in the column headers.
    
    The folder menu is a fitting new home because:
       1. The column changes are saved only for this folder;
       2. If the user right clicks the columns, expecting an option to
          change columns, the option will be right there.
    
    This is part of an effort to drop the view menu.

 src/resources/ui/nautilus-files-view-context-menus.ui | 5 +++++
 src/resources/ui/nautilus-toolbar.ui                  | 7 -------
 2 files changed, 5 insertions(+), 7 deletions(-)
---
diff --git a/src/resources/ui/nautilus-files-view-context-menus.ui 
b/src/resources/ui/nautilus-files-view-context-menus.ui
index ebbe9f5d8..44c58b5ca 100644
--- a/src/resources/ui/nautilus-files-view-context-menus.ui
+++ b/src/resources/ui/nautilus-files-view-context-menus.ui
@@ -24,6 +24,11 @@
       <attribute name="action">win.stop</attribute>
       <attribute name="hidden-when">action-disabled</attribute>
     </item>
+    <item>
+      <attribute name="label" translatable="yes">_Visible Columns…</attribute>
+      <attribute name="action">view.visible-columns</attribute>
+      <attribute name="hidden-when">action-missing</attribute>
+    </item>
     <section>
       <item>
         <attribute name="label" translatable="yes">_Open With Other Application</attribute>
diff --git a/src/resources/ui/nautilus-toolbar.ui b/src/resources/ui/nautilus-toolbar.ui
index 682fff316..e42bb2c46 100644
--- a/src/resources/ui/nautilus-toolbar.ui
+++ b/src/resources/ui/nautilus-toolbar.ui
@@ -13,13 +13,6 @@
            Its contents is provided by the view.
       -->
     </section>
-    <section>
-      <item>
-        <attribute name="label" translatable="yes">_Visible Columns…</attribute>
-        <attribute name="action">view.visible-columns</attribute>
-        <attribute name="hidden-when">action-missing</attribute>
-      </item>
-    </section>
   </menu>
   <menu id="app_menu">
     <section>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]