[orca] gnome-shell: fix regression related to not saying "window"
- From: Joanmarie Diggs <joanied src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [orca] gnome-shell: fix regression related to not saying "window"
- Date: Wed, 27 Apr 2022 08:59:30 +0000 (UTC)
commit b00b59ba441e2fb27246fa950ac8f8ca57762447
Author: Joanmarie Diggs <jdiggs igalia com>
Date: Wed Apr 27 10:56:14 2022 +0200
gnome-shell: fix regression related to not saying "window"
In order to be less chatty, Orca no longer speaks nameless windows
if it is about to speak something in that window as a result of a
queued up focused event. It is possible, however, for that event
to be for the nameless window, which we don't present because it
is already the focused object. Therefore, check that the queued up
focused event is not for the window which just became activated.
See issue #226
src/orca/scripts/apps/gnome-shell/script.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
---
diff --git a/src/orca/scripts/apps/gnome-shell/script.py b/src/orca/scripts/apps/gnome-shell/script.py
index 7e086238f..bf8163617 100644
--- a/src/orca/scripts/apps/gnome-shell/script.py
+++ b/src/orca/scripts/apps/gnome-shell/script.py
@@ -76,7 +76,8 @@ class Script(clutter.Script):
def locusOfFocusChanged(self, event, oldFocus, newFocus):
if (event and event.type == "window:activate" and newFocus and not newFocus.name):
- if self._getQueuedEvent("object:state-changed:focused", True):
+ queuedEvent = self._getQueuedEvent("object:state-changed:focused", True)
+ if queuedEvent and queuedEvent.source != event.source:
msg = "GNOME SHELL: Have matching focused event. Not announcing nameless window."
debug.println(debug.LEVEL_INFO, msg, True)
return
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]