[gnome-software/1727-wrong-direction-of-arrows-in-rtl-languages] Apply 1 suggestion(s) to 1 file(s)



commit 2b0cec751eb24f21aec3ccc0ecc98fef82d147e3
Author: Philip Withnall <philip tecnocode co uk>
Date:   Tue Apr 26 11:09:47 2022 +0000

    Apply 1 suggestion(s) to 1 file(s)

 src/gs-os-update-page.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
---
diff --git a/src/gs-os-update-page.c b/src/gs-os-update-page.c
index bbd75cff3..99bc62081 100644
--- a/src/gs-os-update-page.c
+++ b/src/gs-os-update-page.c
@@ -101,12 +101,8 @@ format_version_update (GsApp *app, GtkTextDirection direction)
            g_strcmp0 (version_current, version_update) != 0) {
                switch (direction) {
                case GTK_TEXT_DIR_RTL:
-                       /* This might look the wrong way round, but that’s
-                        * because the #GtkLabel this is put in will reverse the
-                        * text order in RTL, but won’t swap ← for → or
-                        * vice-versa (the bidi mirroring property of those two
-                        * arrows is false). So we need to explicitly use ‘←’ in
-                        * RTL locales, but not change the text order.
+                       /* ensure the arrow is the right way round for the text direction,
+                        * as arrows are not bidi-mirrored automatically
                         * See section 2 of http://www.unicode.org/L2/L2017/17438-bidi-math-fdbk.html */
                        return g_strdup_printf ("%s ← %s",
                                                version_update,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]