[orca] Remove the not-focusable requirement for clickables in collection match rule



commit 42cb6936f8712e945bafb54ba722779f581a7074
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Mon Apr 25 17:37:27 2022 +0200

    Remove the not-focusable requirement for clickables in collection match rule
    
    This check is redundant to the one in the predicate. So there should be
    no noticeable change in the user experience from this commit.
    
    In addition, there are some focusable elements which we want to treat as
    clickable objects. Making those changes will be done in subsequent commit(s)
    so that any regressions in the user experience can be reverted on a case-
    by-case basis.

 src/orca/structural_navigation.py | 5 -----
 1 file changed, 5 deletions(-)
---
diff --git a/src/orca/structural_navigation.py b/src/orca/structural_navigation.py
index 1a016d3e4..ba4725757 100644
--- a/src/orca/structural_navigation.py
+++ b/src/orca/structural_navigation.py
@@ -3292,12 +3292,7 @@ class StructuralNavigation:
 
         interfaces = ["action"]
         interfaceMatch = collection.MATCH_ANY
-        state = [pyatspi.STATE_FOCUSABLE]
-        stateMatch = collection.MATCH_NONE
-
         return MatchCriteria(collection,
-                             states=state,
-                             matchStates=stateMatch,
                              interfaces=interfaces,
                              matchInterfaces=interfaceMatch,
                              applyPredicate=True)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]