[orca] Event manager: Ignore state-showing true from nameless panels



commit f88e727b50f02fa8e4113c235acb57905506cab5
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Thu Apr 21 13:05:02 2022 +0200

    Event manager: Ignore state-showing true from nameless panels

 src/orca/event_manager.py | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)
---
diff --git a/src/orca/event_manager.py b/src/orca/event_manager.py
index f4fe872ab..691a6def6 100644
--- a/src/orca/event_manager.py
+++ b/src/orca/event_manager.py
@@ -272,10 +272,21 @@ class EventManager:
                 msg = 'EVENT MANAGER: Ignoring event type due to role'
                 debug.println(debug.LEVEL_INFO, msg, True)
                 return True
-            if role == pyatspi.ROLE_PANEL and not event.detail1:
-                msg = 'EVENT MANAGER: Ignoring event type due to role and detail1'
-                debug.println(debug.LEVEL_INFO, msg, True)
-                return True
+            if role == pyatspi.ROLE_PANEL:
+                if not event.detail1:
+                    msg = 'EVENT MANAGER: Ignoring event type due to role and detail1'
+                    debug.println(debug.LEVEL_INFO, msg, True)
+                    return True
+                try:
+                    if not event.source.name:
+                        msg = 'EVENT MANAGER: Ignoring event type due to role and lack of name'
+                        debug.println(debug.LEVEL_INFO, msg, True)
+                        return True
+                except:
+                    msg = 'EVENT MANAGER: Ignoring event from dead source'
+                    debug.println(debug.LEVEL_INFO, msg, True)
+                    return True
+
         elif event.type.startswith('object:selection-changed'):
             if event.source in self._parentsOfDefunctDescendants:
                 msg = 'EVENT MANAGER: Ignoring event from parent of defunct descendants'


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]