[gnome-builder/wip/gtk4-port] plugins/debuggerui: return error if we showed nothing
- From: Christian Hergert <chergert src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-builder/wip/gtk4-port] plugins/debuggerui: return error if we showed nothing
- Date: Thu, 21 Apr 2022 01:17:37 +0000 (UTC)
commit 44b091ea68a7a7d1be152e14974b0f3f45f05209
Author: Christian Hergert <chergert redhat com>
Date: Wed Apr 20 18:17:31 2022 -0700
plugins/debuggerui: return error if we showed nothing
Increase chances GtkSourceView does the right thing.
src/plugins/debuggerui/ide-debugger-hover-provider.c | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
---
diff --git a/src/plugins/debuggerui/ide-debugger-hover-provider.c
b/src/plugins/debuggerui/ide-debugger-hover-provider.c
index 631fe4256..3fd39cc7d 100644
--- a/src/plugins/debuggerui/ide-debugger-hover-provider.c
+++ b/src/plugins/debuggerui/ide-debugger-hover-provider.c
@@ -71,10 +71,7 @@ ide_debugger_hover_provider_populate_async (GtkSourceHoverProvider *provider,
if (!gtk_source_hover_context_get_iter (context, &iter) ||
gtk_source_buffer_iter_has_context_class (GTK_SOURCE_BUFFER (buffer), &iter, "comment"))
- {
- ide_task_return_boolean (task, TRUE);
- IDE_EXIT;
- }
+ IDE_GOTO (empty);
lang_id = ide_buffer_get_language_id (buffer);
icontext = ide_buffer_ref_context (buffer);
@@ -82,15 +79,24 @@ ide_debugger_hover_provider_populate_async (GtkSourceHoverProvider *provider,
file = ide_buffer_get_file (buffer);
line = gtk_text_iter_get_line (&iter);
- if (ide_debug_manager_get_active(dbgmgr) && ide_debug_manager_supports_language (dbgmgr, lang_id))
+ if (ide_debug_manager_get_active (dbgmgr) &&
+ ide_debug_manager_supports_language (dbgmgr, lang_id))
{
GtkWidget *controls;
controls = ide_debugger_hover_controls_new (dbgmgr, file, line + 1);
gtk_source_hover_display_prepend (display, controls);
+
+ ide_task_return_boolean (task, TRUE);
+
+ IDE_EXIT;
}
- ide_task_return_boolean (task, TRUE);
+empty:
+ ide_task_return_new_error (task,
+ G_IO_ERROR,
+ G_IO_ERROR_NOT_SUPPORTED,
+ "Not supported");
IDE_EXIT;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]