[at-spi2-core] Revert "Fix use after free when removing a hung process."



commit d1113a1de5416aa422c918e0b221a4e3eb0022ca
Author: Mike Gorse <mgorse suse com>
Date:   Wed Apr 20 14:38:11 2022 -0500

    Revert "Fix use after free when removing a hung process."
    
    This change causes CI warnings and was likely the wrong fix.
    
    This reverts commit a72fc0c2cd2fb4000028398d6390a715e979b50f.

 registryd/deviceeventcontroller.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/registryd/deviceeventcontroller.c b/registryd/deviceeventcontroller.c
index 3c62fca3..06d7c5e5 100644
--- a/registryd/deviceeventcontroller.c
+++ b/registryd/deviceeventcontroller.c
@@ -896,8 +896,8 @@ reset_hung_process (DBusPendingCall *pending, void *data)
   {
     if (!strcmp (l->data, dest))
     {
-      g_free (l->data);
       hung_processes = g_slist_remove (hung_processes, l->data);
+      g_free (l->data);
       break;
     }
   }
@@ -921,8 +921,8 @@ reset_hung_process_from_ping (DBusPendingCall *pending, void *data)
   {
     if (!strcmp (l->data, data))
     {
-      g_free (l->data);
       hung_processes = g_slist_remove (hung_processes, l->data);
+      g_free (l->data);
       break;
     }
   }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]