GNOME.org
 

[gnome-builder/wip/gtk4-port] plugins/debuggerui: fix various runtime warnings

commit 3126a193bf473166e31092a8393918c78e469825
Author: Christian Hergert <chergert redhat com>
Date:   Mon Apr 18 07:18:36 2022 -0700

    plugins/debuggerui: fix various runtime warnings

 src/plugins/debuggerui/ide-debugger-controls.c     |  1 +
 src/plugins/debuggerui/ide-debugger-controls.ui    | 63 ++++------------------
 src/plugins/debuggerui/ide-debugger-log-view.ui    |  5 +-
 .../debuggerui/ide-debugger-threads-view.ui        |  8 +--
 .../debuggerui/ide-debugger-workspace-addin.c      |  3 --
 5 files changed, 16 insertions(+), 64 deletions(-)
---
diff --git a/src/plugins/debuggerui/ide-debugger-controls.c b/src/plugins/debuggerui/ide-debugger-controls.c
index 2d6e259e4..38a74ac3b 100644
--- a/src/plugins/debuggerui/ide-debugger-controls.c
+++ b/src/plugins/debuggerui/ide-debugger-controls.c
@@ -51,6 +51,7 @@ ide_debugger_controls_class_init (IdeDebuggerControlsClass *klass)
   object_class->dispose = ide_debugger_controls_dispose;
 
   gtk_widget_class_set_template_from_resource (widget_class, "/plugins/debuggerui/ide-debugger-controls.ui");
+  gtk_widget_class_set_layout_manager_type (widget_class, GTK_TYPE_BIN_LAYOUT);
   gtk_widget_class_set_css_name (widget_class, "idedebuggercontrols");
   gtk_widget_class_bind_template_child (widget_class, IdeDebuggerControls, revealer);
 }
diff --git a/src/plugins/debuggerui/ide-debugger-controls.ui b/src/plugins/debuggerui/ide-debugger-controls.ui
index b2ae4bd21..8c5615162 100644
--- a/src/plugins/debuggerui/ide-debugger-controls.ui
+++ b/src/plugins/debuggerui/ide-debugger-controls.ui
@@ -1,18 +1,17 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <interface>
-  <template class="IdeDebuggerControls" parent="GtkRevealer">
+  <template class="IdeDebuggerControls" parent="GtkWidget">
     <child>
       <object class="GtkRevealer" id="revealer">
         <property name="reveal-child">false</property>
         <property name="transition-type">slide-up</property>
-        <property name="transition-duration">300</property>
+        <property name="transition-duration">500</property>
         <child>
           <object class="GtkFrame">
-            <property name="visible">true</property>
+            <property name="margin-bottom">12</property>
             <child>
               <object class="GtkBox">
                 <property name="orientation">horizontal</property>
-                <property name="visible">true</property>
                 <style>
                   <class name="linked"/>
                 </style>
@@ -20,26 +19,14 @@
                   <object class="GtkButton" id="pause_button">
                     <property name="action-name">debugger.stop</property>
                     <property name="tooltip-text" translatable="yes">Interrupt the program</property>
-                    <property name="visible">true</property>
-                    <child>
-                      <object class="GtkImage">
-                        <property name="icon-name">media-playback-pause-symbolic</property>
-                        <property name="visible">true</property>
-                      </object>
-                    </child>
+                    <property name="icon-name">media-playback-pause-symbolic</property>
                   </object>
                 </child>
                 <child>
                   <object class="GtkButton" id="continue_button">
                     <property name="action-name">debugger.continue</property>
                     <property name="tooltip-text" translatable="yes">Continue running the program</property>
-                    <property name="visible">true</property>
-                    <child>
-                      <object class="GtkImage">
-                        <property name="icon-name">debug-continue-symbolic</property>
-                        <property name="visible">true</property>
-                      </object>
-                    </child>
+                    <property name="icon-name">debug-continue-symbolic</property>
                   </object>
                 </child>
                 <!--
@@ -47,26 +34,14 @@
                   <object class="GtkButton" id="execute_from_cursor_button">
                     <property name="action-name">debugger.execute-from-cursor</property>
                     <property name="tooltip-text" translatable="yes">Execute from the current cursor 
position</property>
-                    <property name="visible">true</property>
-                    <child>
-                      <object class="GtkImage">
-                        <property name="icon-name">debug-execute-from-cursor-symbolic</property>
-                        <property name="visible">true</property>
-                      </object>
-                    </child>
+                    <property name="icon-name">debug-execute-from-cursor-symbolic</property>
                   </object>
                 </child>
                 <child>
                   <object class="GtkButton" id="execute_to_cursor_button">
                     <property name="action-name">debugger.execute-to-cursor</property>
                     <property name="tooltip-text" translatable="yes">Execute until reaching the current 
cursor position</property>
-                    <property name="visible">true</property>
-                    <child>
-                      <object class="GtkImage">
-                        <property name="icon-name">debug-execute-to-cursor-symbolic</property>
-                        <property name="visible">true</property>
-                      </object>
-                    </child>
+                  <property name="icon-name">debug-execute-to-cursor-symbolic</property>
                   </object>
                 </child>
                 -->
@@ -74,39 +49,21 @@
                   <object class="GtkButton" id="step_in_button">
                     <property name="action-name">debugger.step-in</property>
                     <property name="tooltip-text" translatable="yes">Execute the current line, stepping into 
any function calls</property>
-                    <property name="visible">true</property>
-                    <child>
-                      <object class="GtkImage">
-                        <property name="icon-name">debug-step-in-symbolic</property>
-                        <property name="visible">true</property>
-                      </object>
-                    </child>
+                    <property name="icon-name">debug-step-in-symbolic</property>
                   </object>
                 </child>
                 <child>
                   <object class="GtkButton" id="step_over_button">
                     <property name="action-name">debugger.step-over</property>
                     <property name="tooltip-text" translatable="yes">Execute the current line, stepping over 
any function calls</property>
-                    <property name="visible">true</property>
-                    <child>
-                      <object class="GtkImage">
-                        <property name="icon-name">debug-step-over-symbolic</property>
-                        <property name="visible">true</property>
-                      </object>
-                    </child>
+                    <property name="icon-name">debug-step-over-symbolic</property>
                   </object>
                 </child>
                 <child>
                   <object class="GtkButton" id="finish_button">
                     <property name="action-name">debugger.finish</property>
                     <property name="tooltip-text" translatable="yes">Run until the end of the 
function</property>
-                    <property name="visible">true</property>
-                    <child>
-                      <object class="GtkImage">
-                        <property name="icon-name">debug-step-out-symbolic</property>
-                        <property name="visible">true</property>
-                      </object>
-                    </child>
+                    <property name="icon-name">debug-step-out-symbolic</property>
                   </object>
                 </child>
               </object>
diff --git a/src/plugins/debuggerui/ide-debugger-log-view.ui b/src/plugins/debuggerui/ide-debugger-log-view.ui
index b66fc2afb..0430f07dc 100644
--- a/src/plugins/debuggerui/ide-debugger-log-view.ui
+++ b/src/plugins/debuggerui/ide-debugger-log-view.ui
@@ -35,7 +35,10 @@
           <object class="GtkEntry" id="commandentry">
             <property name="primary-icon-name">pan-end-symbolic</property>
             <property name="visible">True</property>
-            <property name="margin">6</property>
+            <property name="margin-top">6</property>
+            <property name="margin-bottom">6</property>
+            <property name="margin-start">6</property>
+            <property name="margin-end">6</property>
             <property name="hexpand">True</property>
             <signal name="activate" handler="on_entry_activate" swapped="yes" object="IdeDebuggerLogView"/>
             <style>
diff --git a/src/plugins/debuggerui/ide-debugger-threads-view.ui 
b/src/plugins/debuggerui/ide-debugger-threads-view.ui
index 51dc49d9a..b8cc72683 100644
--- a/src/plugins/debuggerui/ide-debugger-threads-view.ui
+++ b/src/plugins/debuggerui/ide-debugger-threads-view.ui
@@ -2,9 +2,8 @@
 <interface>
   <template class="IdeDebuggerThreadsView" parent="AdwBin">
     <child>
-      <object class="IdeMultiPaned">
+      <object class="PanelPaned">
         <property name="orientation">horizontal</property>
-        <property name="visible">true</property>
         <child>
           <object class="GtkScrolledWindow">
             <!-- disable for now -->
@@ -13,7 +12,6 @@
               <object class="GtkTreeView" id="thread_groups_tree_view">
                 <property name="activate-on-single-click">true</property>
                 <property name="model">thread_groups_store</property>
-                <property name="visible">true</property>
                 <child>
                   <object class="GtkTreeViewColumn" id="group_column">
                     <property name="title" translatable="yes">Group</property>
@@ -31,12 +29,10 @@
         <child>
           <object class="GtkScrolledWindow">
             <property name="hscrollbar-policy">never</property>
-            <property name="visible">true</property>
             <child>
               <object class="GtkTreeView" id="threads_tree_view">
                 <property name="activate-on-single-click">true</property>
                 <property name="model">threads_store</property>
-                <property name="visible">true</property>
                 <child>
                   <object class="GtkTreeViewColumn" id="thread_column">
                     <property name="title" translatable="yes">Thread</property>
@@ -53,12 +49,10 @@
         </child>
         <child>
           <object class="GtkScrolledWindow">
-            <property name="visible">true</property>
             <child>
               <object class="GtkTreeView" id="frames_tree_view">
                 <property name="activate-on-single-click">true</property>
                 <property name="model">frames_store</property>
-                <property name="visible">true</property>
                 <child>
                   <object class="GtkTreeViewColumn" id="depth_column">
                     <property name="title" translatable="yes">Frame</property>
diff --git a/src/plugins/debuggerui/ide-debugger-workspace-addin.c 
b/src/plugins/debuggerui/ide-debugger-workspace-addin.c
index e1cba10ea..965829d2e 100644
--- a/src/plugins/debuggerui/ide-debugger-workspace-addin.c
+++ b/src/plugins/debuggerui/ide-debugger-workspace-addin.c
@@ -272,9 +272,6 @@ ide_debugger_workspace_addin_add_ui (IdeDebuggerWorkspaceAddin *self)
   g_assert (self->workspace != NULL);
 
   self->controls = g_object_new (IDE_TYPE_DEBUGGER_CONTROLS,
-                                 "transition-duration", 500,
-                                 "transition-type", GTK_REVEALER_TRANSITION_TYPE_SLIDE_UP,
-                                 "reveal-child", FALSE,
                                  "halign", GTK_ALIGN_CENTER,
                                  "valign", GTK_ALIGN_END,
                                  NULL);
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]