[gspell] build: ax_code_coverage.m4: temporary fix to silence a warning



commit 82c98195eae671e54a6bc8a7c8a63f23af710e4b
Author: Sébastien Wilmet <swilmet informatique-libre be>
Date:   Thu Apr 14 17:14:12 2022 +0200

    build: ax_code_coverage.m4: temporary fix to silence a warning
    
    In the *.m4 file, do not try to set/modify AM_DISTCHECK_CONFIGURE_FLAGS.
    Do it in the Makefile.am.
    
    Ideally this should be properly fixed in the *.m4 file, upstream in
    autoconf-archive (I've already reported the bug).
    
    The warning was, in 3 lines:
    
    ```
    Makefile.am:7: warning: AM_DISTCHECK_CONFIGURE_FLAGS was already defined in
    condition CODE_COVERAGE_ENABLED, which is included in condition TRUE ...
    
    aminclude_static.am:100: ... 'AM_DISTCHECK_CONFIGURE_FLAGS' previously defined
    here
    
    Makefile.am:3:   'aminclude_static.am' included from here
    ```
    
    So, what the *.m4 file was trying to do, is (I suppose), to add
    --disable-code-coverage to AM_DISTCHECK_CONFIGURE_FLAGS inside these
    conditions:
    ```
    if CODE_COVERAGE_ENABLED
     ifeq (\$(abs_builddir), \$(abs_top_builddir))
    ```

 Makefile.am            | 6 +++++-
 m4/ax_code_coverage.m4 | 2 +-
 2 files changed, 6 insertions(+), 2 deletions(-)
---
diff --git a/Makefile.am b/Makefile.am
index 29f0f77..7b44d7d 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -4,7 +4,11 @@ include $(top_srcdir)/aminclude_static.am
 clean-local: code-coverage-clean
 distclean-local: code-coverage-dist-clean
 
-AM_DISTCHECK_CONFIGURE_FLAGS = --enable-gtk-doc --enable-introspection --enable-vala
+AM_DISTCHECK_CONFIGURE_FLAGS = \
+       --enable-gtk-doc \
+       --enable-introspection \
+       --enable-vala \
+       --disable-code-coverage
 
 pkgconfig_DATA = gspell-$(GSPELL_API_VERSION).pc
 DISTCLEANFILES = $(pkgconfig_DATA)
diff --git a/m4/ax_code_coverage.m4 b/m4/ax_code_coverage.m4
index 352165b..fa73b10 100644
--- a/m4/ax_code_coverage.m4
+++ b/m4/ax_code_coverage.m4
@@ -175,7 +175,7 @@ code-coverage-clean:
 
 code-coverage-dist-clean:
 
-A][M_DISTCHECK_CONFIGURE_FLAGS := \$(A][M_DISTCHECK_CONFIGURE_FLAGS) --disable-code-coverage
+# A][M_DISTCHECK_CONFIGURE_FLAGS := \$(A][M_DISTCHECK_CONFIGURE_FLAGS) --disable-code-coverage
  else # ifneq (\$(abs_builddir), \$(abs_top_builddir))
 check-code-coverage:
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]