[epiphany/mcatanzaro/#1746: 10/10] web-view: fix critical in open_response_cb
- From: Marge Bot <marge-bot src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany/mcatanzaro/#1746: 10/10] web-view: fix critical in open_response_cb
- Date: Mon, 11 Apr 2022 15:35:50 +0000 (UTC)
commit 3957d0ae7ca7cd0fd4de5750ecf1bc39fc667639
Author: Michael Catanzaro <mcatanzaro redhat com>
Date: Fri Apr 8 14:53:37 2022 -0500
web-view: fix critical in open_response_cb
Turns out gtk_file_chooser_get_current_folder_file() may return NULL.
Fixes #1746
Part-of: <https://gitlab.gnome.org/GNOME/epiphany/-/merge_requests/1104>
embed/ephy-web-view.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
---
diff --git a/embed/ephy-web-view.c b/embed/ephy-web-view.c
index d8521a012..4bccbcb46 100644
--- a/embed/ephy-web-view.c
+++ b/embed/ephy-web-view.c
@@ -176,10 +176,12 @@ open_response_cb (GtkFileChooser *dialog,
g_ptr_array_free (file_array, TRUE);
current_folder = gtk_file_chooser_get_current_folder_file (dialog);
- current_folder_path = g_file_get_path (current_folder);
- g_settings_set_string (EPHY_SETTINGS_WEB,
- EPHY_PREFS_WEB_LAST_UPLOAD_DIRECTORY,
- current_folder_path);
+ if (current_folder) {
+ current_folder_path = g_file_get_path (current_folder);
+ g_settings_set_string (EPHY_SETTINGS_WEB,
+ EPHY_PREFS_WEB_LAST_UPLOAD_DIRECTORY,
+ current_folder_path);
+ }
} else {
webkit_file_chooser_request_cancel (request);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]