[epiphany/mcatanzaro/#1733: 4/7] download: downgrade inappropriate critical




commit e9a5279e1da936580f1c4949674069a8310dcc5f
Author: Michael Catanzaro <mcatanzaro redhat com>
Date:   Tue Apr 5 15:18:44 2022 -0500

    download: downgrade inappropriate critical
    
    g_critical() is for programmer errors, not for I/O errors.
    
    Part-of: <https://gitlab.gnome.org/GNOME/epiphany/-/merge_requests/1103>

 embed/ephy-download.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/embed/ephy-download.c b/embed/ephy-download.c
index 652d52512..cb03f3828 100644
--- a/embed/ephy-download.c
+++ b/embed/ephy-download.c
@@ -204,8 +204,8 @@ set_destination_uri_for_suggested_filename (EphyDownload *download,
 
   /* Make sure the download directory exists */
   if (g_mkdir_with_parents (dest_dir, 0700) == -1) {
-    g_critical ("Could not create downloads directory \"%s\": %s",
-                dest_dir, strerror (errno));
+    g_warning ("Could not create downloads directory \"%s\": %s",
+               dest_dir, strerror (errno));
     g_free (dest_dir);
     return FALSE;
   }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]