[evince/wip/hadess/comics-crasher] comics: Fix use-after-free




commit ebe8a726fadcdd3a316549d49afadc23bf0d9b94
Author: Bastien Nocera <hadess hadess net>
Date:   Mon Apr 4 13:08:33 2022 +0200

    comics: Fix use-after-free
    
    Fix use-after-free when attempting to access files after the archive
    has been reset. We would try to avoid reopening the archive but it was
    already closed and the entry was pointing to invalid memory.
    
    Fixes: b1732c19af3d4adf1fc481e0e72a0cbf34240c18
    Closes: #1776

 backend/comics/ev-archive.c | 1 +
 1 file changed, 1 insertion(+)
---
diff --git a/backend/comics/ev-archive.c b/backend/comics/ev-archive.c
index 6586482b6..568e16215 100644
--- a/backend/comics/ev-archive.c
+++ b/backend/comics/ev-archive.c
@@ -310,6 +310,7 @@ ev_archive_reset (EvArchive *archive)
        case EV_ARCHIVE_TYPE_TAR:
                g_clear_pointer (&archive->libar, archive_free);
                libarchive_set_archive_type (archive, archive->type);
+               archive->libar_entry = NULL;
                break;
        default:
                g_assert_not_reached ();


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]