[gupnp] service-proxy-test: Fix missing action and error



commit 2ee32360efc5c90e9f5c1512b60e36c5b870b7db
Author: Jens Georg <mail jensge org>
Date:   Sat Apr 2 10:56:20 2022 +0200

    service-proxy-test: Fix missing action and error
    
    The error check was in the wrong position thus the test was not
    sensitive to the Browse action not being implemented

 tests/test-service-proxy.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
---
diff --git a/tests/test-service-proxy.c b/tests/test-service-proxy.c
index 347ea73..3388723 100644
--- a/tests/test-service-proxy.c
+++ b/tests/test-service-proxy.c
@@ -222,12 +222,12 @@ void
 on_test_async_call (GObject *source, GAsyncResult *res, gpointer user_data)
 {
         GError *error = NULL;
-        g_assert_no_error (error);
         g_assert_nonnull (user_data);
 
         gupnp_service_proxy_call_action_finish (GUPNP_SERVICE_PROXY (source),
                                                 res,
                                                 &error);
+        g_assert_no_error (error);
 
         ProxyTestFixture *tf = (ProxyTestFixture *) user_data;
         g_main_loop_quit (tf->loop);
@@ -245,6 +245,11 @@ test_async_call (ProxyTestFixture *tf, G_GNUC_UNUSED gconstpointer user_data)
                           G_CALLBACK (on_test_async_call_ping_success),
                           tf);
 
+        g_signal_connect (tf->service,
+                          "action-invoked::Browse",
+                          G_CALLBACK (on_test_async_call_ping_success),
+                          tf);
+
         gupnp_service_proxy_call_action_async (tf->proxy,
                                                action,
                                                NULL,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]