[orca] Don't fall back accessible name for displayed text in spin button

[Joanmarie Diggs <joanied src gnome org>]

commit 30e2d362550726ce6069d3f792253caf42f0483b
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Mon Sep 20 12:57:10 2021 +0200

    Don't fall back accessible name for displayed text in spin button
    
    When getting the displayed text of something which claims to implement
    the accessible text interface but then doesn't, we fall back on the
    name. That doesn't make sense for a spin button in general. In addition,
    there seems to be a bug in Chrome/Chromium in which spin buttons which
    display text fail to expose that text via the text interface. Falling
    back on the name prevents other checks (e.g. valuetext property) from
    happening. So this change in Orca will work around that issue in
    Chrome/Chromium.

 src/orca/script_utilities.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/orca/script_utilities.py b/src/orca/script_utilities.py
index 219231ebf..caa984fa7 100644
--- a/src/orca/script_utilities.py
+++ b/src/orca/script_utilities.py
@@ -555,7 +555,7 @@ class Utilities:
             if self.EMBEDDED_OBJECT_CHARACTER in displayedText:
                 displayedText = None
 
-        if not displayedText and role != pyatspi.ROLE_COMBO_BOX:
+        if not displayedText and role not in [pyatspi.ROLE_COMBO_BOX, pyatspi.ROLE_SPIN_BUTTON]:
             # TODO - JD: This should probably get nuked. But all sorts of
             # existing code might be relying upon this bogus hack. So it
             # will need thorough testing when removed.