[gnome-music/wip/mschraal/asyncqueue-fixes: 5/6] Remove unneeded "generic" thumbnail setters




commit 40643bc8778aa194dde7f8baf5f87fa718fd230d
Author: Marinus Schraal <mschraal gnome org>
Date:   Fri Sep 10 12:22:08 2021 +0200

    Remove unneeded "generic" thumbnail setters
    
    After the art rework it is no longer needed to set the thumbnail uri to
    "generic" as it is already set to that by default. This also triggers an
    unneeded art update.
    
    Remove unneeded "generic" setters.

 gnomemusic/albumart.py                        | 1 -
 gnomemusic/artistart.py                       | 1 -
 gnomemusic/grilowrappers/grltrackerwrapper.py | 4 ----
 gnomemusic/songart.py                         | 1 -
 gnomemusic/storeart.py                        | 3 ---
 5 files changed, 10 deletions(-)
---
diff --git a/gnomemusic/albumart.py b/gnomemusic/albumart.py
index 7a8f6a12a..f61db97e9 100644
--- a/gnomemusic/albumart.py
+++ b/gnomemusic/albumart.py
@@ -62,7 +62,6 @@ class AlbumArt(GObject.GObject):
         success, thumb_file = MediaArt.get_file(
             self._artist, self._album, "album")
         if not success:
-            self._corealbum.props.thumbnail = "generic"
             return
 
         def on_file_exists_async_finished(obj, result):
diff --git a/gnomemusic/artistart.py b/gnomemusic/artistart.py
index 04d913c76..6605748c8 100644
--- a/gnomemusic/artistart.py
+++ b/gnomemusic/artistart.py
@@ -54,7 +54,6 @@ class ArtistArt(GObject.GObject):
         success, thumb_file = MediaArt.get_file(self._artist, None, "artist")
 
         if not success:
-            self._coreartist.props.thumbnail = "generic"
             return
 
         def on_file_exists_async_finished(obj, result):
diff --git a/gnomemusic/grilowrappers/grltrackerwrapper.py b/gnomemusic/grilowrappers/grltrackerwrapper.py
index 1b65fab97..7567275a4 100644
--- a/gnomemusic/grilowrappers/grltrackerwrapper.py
+++ b/gnomemusic/grilowrappers/grltrackerwrapper.py
@@ -1218,7 +1218,6 @@ class GrlTrackerWrapper(GObject.GObject):
         if (media.get_album() is None
                 and (media.get_album_artist() is None
                      or media.get_artist() is None)):
-            coresong.props.thumbnail = "generic"
             return
 
         def art_retrieved_cb(
@@ -1227,7 +1226,6 @@ class GrlTrackerWrapper(GObject.GObject):
                 error: Optional[GLib.Error]) -> None:
             if error:
                 self._log.warning("Error: {}".format(error))
-                coresong.props.thumbnail = "generic"
                 return
 
             if queried_media is None:
@@ -1256,7 +1254,6 @@ class GrlTrackerWrapper(GObject.GObject):
                 error: Optional[GLib.Error]) -> None:
             if error:
                 self._log.warning("Error: {}".format(error))
-                corealbum.props.thumbnail = "generic"
                 return
 
             if queried_media is None:
@@ -1287,7 +1284,6 @@ class GrlTrackerWrapper(GObject.GObject):
                 error: Optional[GLib.Error]) -> None:
             if error:
                 self._log.warning("Error: {}".format(error))
-                coreartist.props.thumbnail = "generic"
                 return
 
             if resolved_media is None:
diff --git a/gnomemusic/songart.py b/gnomemusic/songart.py
index 94bf46c90..4058aa0cc 100644
--- a/gnomemusic/songart.py
+++ b/gnomemusic/songart.py
@@ -62,7 +62,6 @@ class SongArt(GObject.GObject):
         success, thumb_file = MediaArt.get_file(
             self._artist, self._album, "album")
         if not success:
-            self._coresong.props.thumbnail = "generic"
             return
 
         def on_file_exists_async_finished(obj, result):
diff --git a/gnomemusic/storeart.py b/gnomemusic/storeart.py
index c24508adb..a81a32fe3 100644
--- a/gnomemusic/storeart.py
+++ b/gnomemusic/storeart.py
@@ -59,7 +59,6 @@ class StoreArt(GObject.Object):
 
         if (uri is None
                 or uri == ""):
-            self._coreobject.props.thumbnail = "generic"
             self.emit("finished")
             return
 
@@ -78,7 +77,6 @@ class StoreArt(GObject.Object):
             success = False
 
         if not success:
-            self._coreobject.props.thumbnail = "generic"
             self.emit("finished")
             return
 
@@ -99,7 +97,6 @@ class StoreArt(GObject.Object):
             except GLib.Error as error:
                 self._log.warning(
                     "Error: {}, {}".format(error.domain, error.message))
-                self._coreobject.props.thumbnail = "generic"
                 self.emit("finished")
                 return
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]