[librsvg: 1/2] Clarify usage of the write/close deprecated APIs
- From: Marge Bot <marge-bot src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [librsvg: 1/2] Clarify usage of the write/close deprecated APIs
- Date: Fri, 17 Sep 2021 18:47:03 +0000 (UTC)
commit 76a7d6e889b01fd865f869fccdff116f4294cd0d
Author: Federico Mena Quintero <federico gnome org>
Date: Fri Sep 17 13:28:58 2021 -0500
Clarify usage of the write/close deprecated APIs
Saw some misconceptions in some client code; hopefully this clarifies things.
Part-of: <https://gitlab.gnome.org/GNOME/librsvg/-/merge_requests/590>
include/librsvg/rsvg.h | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
---
diff --git a/include/librsvg/rsvg.h b/include/librsvg/rsvg.h
index 2ecf2604..d222b75e 100644
--- a/include/librsvg/rsvg.h
+++ b/include/librsvg/rsvg.h
@@ -575,7 +575,9 @@ RsvgHandle *rsvg_handle_new (void);
* @count: length of the @buf buffer in bytes
* @error: (optional): a location to store a #GError, or %NULL
*
- * Loads the next @count bytes of the image.
+ * Loads the next @count bytes of the image. You can call this function multiple
+ * times until the whole document is consumed; then you must call rsvg_handle_close()
+ * to actually parse the document.
*
* Before calling this function for the first time, you may need to call
* rsvg_handle_set_base_uri() or rsvg_handle_set_base_gfile() to set the "base
@@ -603,9 +605,15 @@ gboolean rsvg_handle_write (RsvgHandle *handle,
* @handle: a #RsvgHandle
* @error: (optional): a location to store a #GError, or %NULL
*
- * Closes @handle, to indicate that loading the image is complete. This will
- * return %TRUE if the loader closed successfully and the SVG data was parsed
- * correctly. Note that @handle isn't freed until @g_object_unref is called.
+ * This is used after calling rsvg_handle_write() to indicate that there is no more data
+ * to consume, and to start the actual parsing of the SVG document. The only reason to
+ * call this function is if you use use rsvg_handle_write() to feed data into the @handle;
+ * if you use the other methods like rsvg_handle_new_from_file() or
+ * rsvg_handle_read_stream_sync(), then you do not need to call this function.
+ *
+ * This will return %TRUE if the loader closed successfully and the
+ * SVG data was parsed correctly. Note that @handle isn't freed until
+ * @g_object_unref is called.
*
* Returns: %TRUE on success, or %FALSE on error.
*
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]