[libhandy] themes: Don’t change background of non-activatable rows on :active
- From: Alexander Mikhaylenko <alexm src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [libhandy] themes: Don’t change background of non-activatable rows on :active
- Date: Wed, 15 Sep 2021 10:42:31 +0000 (UTC)
commit 9d043f0345fb1b0deddb4c80fd34430a14c91261
Author: Philip Withnall <pwithnall endlessos org>
Date: Wed Sep 15 11:23:23 2021 +0100
themes: Don’t change background of non-activatable rows on :active
See https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1382
Drop the `:not(:active)` selector from rules which also have a
`:not(.activatable)` selector. The latter implies that the `:active`
state should be ignored.
Signed-off-by: Philip Withnall <pwithnall endlessos org>
src/themes/Adwaita-dark.css | 2 +-
src/themes/Adwaita.css | 2 +-
src/themes/HighContrast.css | 2 +-
src/themes/HighContrastInverse.css | 2 +-
src/themes/_Adwaita-base.scss | 4 ++--
5 files changed, 6 insertions(+), 6 deletions(-)
---
diff --git a/src/themes/Adwaita-dark.css b/src/themes/Adwaita-dark.css
index 1b969c0e..ed50472d 100644
--- a/src/themes/Adwaita-dark.css
+++ b/src/themes/Adwaita-dark.css
@@ -202,7 +202,7 @@ list.content list.nested > row:not(:active):not(:hover):not(:selected), list.con
list.content list.nested > row.activatable:not(:active):hover:not(:selected) { background-color:
mix(#eeeeec, #2d2d2d, 0.95); }
-list.content > row:not(.expander):not(:active):not(:hover):not(:selected), list.content >
row:not(.expander):not(:active):hover:not(.activatable):not(:selected), list.content > row.expander
row.header:not(:active):not(:hover):not(:selected), list.content > row.expander
row.header:not(:active):hover:not(.activatable):not(:selected) { background-color: #2d2d2d; }
+list.content > row:not(.expander):not(:active):not(:hover):not(:selected), list.content >
row:not(.expander):hover:not(.activatable):not(:selected), list.content > row.expander
row.header:not(:active):not(:hover):not(:selected), list.content > row.expander
row.header:hover:not(.activatable):not(:selected) { background-color: #2d2d2d; }
list.content > row.activatable:not(.expander):not(:active):hover:not(:selected), list.content > row.expander
row.header.activatable:not(:active):hover:not(:selected) { background-color: mix(#eeeeec, #2d2d2d, 0.95); }
diff --git a/src/themes/Adwaita.css b/src/themes/Adwaita.css
index 34b553ce..677d4d78 100644
--- a/src/themes/Adwaita.css
+++ b/src/themes/Adwaita.css
@@ -202,7 +202,7 @@ list.content list.nested > row:not(:active):not(:hover):not(:selected), list.con
list.content list.nested > row.activatable:not(:active):hover:not(:selected) { background-color:
mix(#2e3436, #ffffff, 0.95); }
-list.content > row:not(.expander):not(:active):not(:hover):not(:selected), list.content >
row:not(.expander):not(:active):hover:not(.activatable):not(:selected), list.content > row.expander
row.header:not(:active):not(:hover):not(:selected), list.content > row.expander
row.header:not(:active):hover:not(.activatable):not(:selected) { background-color: #ffffff; }
+list.content > row:not(.expander):not(:active):not(:hover):not(:selected), list.content >
row:not(.expander):hover:not(.activatable):not(:selected), list.content > row.expander
row.header:not(:active):not(:hover):not(:selected), list.content > row.expander
row.header:hover:not(.activatable):not(:selected) { background-color: #ffffff; }
list.content > row.activatable:not(.expander):not(:active):hover:not(:selected), list.content > row.expander
row.header.activatable:not(:active):hover:not(:selected) { background-color: mix(#2e3436, #ffffff, 0.95); }
diff --git a/src/themes/HighContrast.css b/src/themes/HighContrast.css
index 30584398..42633e0c 100644
--- a/src/themes/HighContrast.css
+++ b/src/themes/HighContrast.css
@@ -202,7 +202,7 @@ list.content list.nested > row:not(:active):not(:hover):not(:selected), list.con
list.content list.nested > row.activatable:not(:active):hover:not(:selected) { background-color:
mix(#272c2e, #ffffff, 0.95); }
-list.content > row:not(.expander):not(:active):not(:hover):not(:selected), list.content >
row:not(.expander):not(:active):hover:not(.activatable):not(:selected), list.content > row.expander
row.header:not(:active):not(:hover):not(:selected), list.content > row.expander
row.header:not(:active):hover:not(.activatable):not(:selected) { background-color: #ffffff; }
+list.content > row:not(.expander):not(:active):not(:hover):not(:selected), list.content >
row:not(.expander):hover:not(.activatable):not(:selected), list.content > row.expander
row.header:not(:active):not(:hover):not(:selected), list.content > row.expander
row.header:hover:not(.activatable):not(:selected) { background-color: #ffffff; }
list.content > row.activatable:not(.expander):not(:active):hover:not(:selected), list.content > row.expander
row.header.activatable:not(:active):hover:not(:selected) { background-color: mix(#272c2e, #ffffff, 0.95); }
diff --git a/src/themes/HighContrastInverse.css b/src/themes/HighContrastInverse.css
index ac0bda3e..864a0904 100644
--- a/src/themes/HighContrastInverse.css
+++ b/src/themes/HighContrastInverse.css
@@ -202,7 +202,7 @@ list.content list.nested > row:not(:active):not(:hover):not(:selected), list.con
list.content list.nested > row.activatable:not(:active):hover:not(:selected) { background-color:
mix(#f3f3f1, #2d2d2d, 0.95); }
-list.content > row:not(.expander):not(:active):not(:hover):not(:selected), list.content >
row:not(.expander):not(:active):hover:not(.activatable):not(:selected), list.content > row.expander
row.header:not(:active):not(:hover):not(:selected), list.content > row.expander
row.header:not(:active):hover:not(.activatable):not(:selected) { background-color: #2d2d2d; }
+list.content > row:not(.expander):not(:active):not(:hover):not(:selected), list.content >
row:not(.expander):hover:not(.activatable):not(:selected), list.content > row.expander
row.header:not(:active):not(:hover):not(:selected), list.content > row.expander
row.header:hover:not(.activatable):not(:selected) { background-color: #2d2d2d; }
list.content > row.activatable:not(.expander):not(:active):hover:not(:selected), list.content > row.expander
row.header.activatable:not(:active):hover:not(:selected) { background-color: mix(#f3f3f1, #2d2d2d, 0.95); }
diff --git a/src/themes/_Adwaita-base.scss b/src/themes/_Adwaita-base.scss
index bd32b631..997e4d90 100644
--- a/src/themes/_Adwaita-base.scss
+++ b/src/themes/_Adwaita-base.scss
@@ -243,9 +243,9 @@ list.content {
> row {
// Regular rows and expander header rows background
&:not(.expander):not(:active):not(:hover):not(:selected),
- &:not(.expander):not(:active):hover:not(.activatable):not(:selected),
+ &:not(.expander):hover:not(.activatable):not(:selected),
&.expander row.header:not(:active):not(:hover):not(:selected),
- &.expander row.header:not(:active):hover:not(.activatable):not(:selected) {
+ &.expander row.header:hover:not(.activatable):not(:selected) {
background-color: $base_color;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]