[gnome-commander] Reducing scope of msg variable, removing a comment



commit c565eb29b3c3c9e48da29fad4ca86e2974af420c
Author: Uwe Scholz <u scholz83 gmx de>
Date:   Tue Sep 14 21:34:18 2021 +0200

    Reducing scope of msg variable, removing a comment

 src/gnome-cmd-xfer.cc | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)
---
diff --git a/src/gnome-cmd-xfer.cc b/src/gnome-cmd-xfer.cc
index 84458ad6..df674a68 100644
--- a/src/gnome-cmd-xfer.cc
+++ b/src/gnome-cmd-xfer.cc
@@ -358,13 +358,13 @@ static void run_move_overwrite_dialog(XferData *xferData)
 //ToDo: Merge with 'update_transfer_gui_error_copy'
 static void update_transfer_gui_error_move (XferData *xferData)
 {
-    gchar *msg = g_strdup_printf (_("Error while transferring ā€œ%sā€\n\n%s"),
-                                    g_file_peek_path(xferData->problemSrcGFile),
-                                    xferData->error->message);
-
     if(!g_error_matches(xferData->error, G_IO_ERROR, G_IO_ERROR_EXISTS))
     {
+        gchar *msg = g_strdup_printf (_("Error while transferring ā€œ%sā€\n\n%s"),
+                                        g_file_peek_path(xferData->problemSrcGFile),
+                                        xferData->error->message);
         run_simple_error_dialog(msg, xferData);
+        g_free (msg);
     }
     else
     {
@@ -392,7 +392,6 @@ static void update_transfer_gui_error_move (XferData *xferData)
         }
         gdk_threads_leave ();
     }
-    g_free (msg);
 }
 
 static gboolean update_transfer_gui (XferData *xferData)
@@ -445,8 +444,6 @@ static gboolean update_transfer_gui (XferData *xferData)
             xferData->win = nullptr;
         }
 
-        // ToDo: If more than one file should be transferred and one file could not be
-        // transferred successsfully, we have to check for this error here
         if (xferData->problem_action == COPY_ERROR_ACTION_NO_ACTION_YET
             && xferData->on_completed_func)
         {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]