[gnome-software/1424-updates-page-clicking-os-updates-generates-runtime-warning] gs-update-dialog: Connect to "back-clicked" signal only for the app details page



commit d29ff17d5db1347e8f75862ad27a6b699aff3c05
Author: Milan Crha <mcrha redhat com>
Date:   Thu Sep 9 19:20:32 2021 +0200

    gs-update-dialog: Connect to "back-clicked" signal only for the app details page
    
    The OS update page does not have where to go back, the button there
    will be removed in the following commit.

 src/gs-update-dialog.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/gs-update-dialog.c b/src/gs-update-dialog.c
index dbefe1041..a7e211c5d 100644
--- a/src/gs-update-dialog.c
+++ b/src/gs-update-dialog.c
@@ -204,11 +204,11 @@ gs_update_dialog_show_update_details (GsUpdateDialog *dialog, GsApp *app)
        } else {
                page = gs_app_details_page_new ();
                gs_app_details_page_set_app (GS_APP_DETAILS_PAGE (page), app);
+               g_signal_connect (page, "back-clicked",
+                                 G_CALLBACK (back_clicked_cb), dialog);
        }
 
        gtk_widget_show (page);
-       g_signal_connect (page, "back-clicked",
-                         G_CALLBACK (back_clicked_cb), dialog);
 
        gtk_container_add (GTK_CONTAINER (dialog->deck), page);
        hdy_deck_set_visible_child (HDY_DECK (dialog->deck), page);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]