[polari] app: Force dispose when removing window
- From: Marge Bot <marge-bot src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [polari] app: Force dispose when removing window
- Date: Fri, 3 Sep 2021 21:23:35 +0000 (UTC)
commit 3fa3eb96fa5cd71ccb4e810f4e602fdaaf79d0aa
Author: Florian Müllner <fmuellner gnome org>
Date: Mon Jul 26 21:05:44 2021 +0200
app: Force dispose when removing window
In GTK4, gtk_window_destroy() will only release the reference
held by GTK itself, which isn't necessarily enough to dispose
the window (and thus emit the ::destroy signal).
That's particularly true for language bindings, so help out with
an explicit run_dispose() call.
Part-of: <https://gitlab.gnome.org/GNOME/polari/-/merge_requests/230>
src/application.js | 2 ++
1 file changed, 2 insertions(+)
---
diff --git a/src/application.js b/src/application.js
index 37190dd1..2bcd5d9d 100644
--- a/src/application.js
+++ b/src/application.js
@@ -446,6 +446,8 @@ export default GObject.registerClass({
this._toplevelSignals.forEach(id => window.disconnect(id));
this._toplevelSignals = [];
+
+ window.run_dispose();
}
vfunc_open(files) {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]