[gtk/gtk-4-4] Do not require wayland-protocols as dependency in the .pc file



commit f99b35162c57ec31b4ea2565e75741dc861cfb78
Author: muradm <muradm>
Date:   Thu Sep 16 17:53:00 2021 +0300

    Do not require wayland-protocols as dependency in the .pc file
    
    Basically, I was building some packages on Guix. I figured out that
    wayland-protocols was listed among propagated-inputs for gtk+ package
    (gtk-3-24). propagated-inputs holds a list of runtime dependencies,
    that should be available to any other package that depends on gtk+.
    While discussing we clarified that wayland-protocols is not runtime
    dependency. So I moved it to native-inputs of gtk+ package, which
    means that, this dependency will be available only to gtk+ package and
    only at build time. Once moved, building of other applications that
    depening on gtk+ started to fail.
    
    Investigation showed that, all .pc (pkg-config) files prepared by gtk+
    package, was including:
    
    Requires.private: ... wayland-protocols ...
    
    Since it becomes requirement, other applications was failing with
    missing dependency wayland-protocols of dependency gtk+, for instance:
    
    -- Checking for module 'gtk+-3.0'
    --   Package 'wayland-protocols', required by 'gdk-3.0', not found
    
    While actually wayland-protocols is not even a build time dependency
    of application that depends on gtk+. Advertisement of such
    requirement, is a bit misleading, because one does not need it at
    runtime, especially applications based on gtk.

 meson.build | 1 -
 1 file changed, 1 deletion(-)
---
diff --git a/meson.build b/meson.build
index 2646a97d2e..2f1e9f7530 100644
--- a/meson.build
+++ b/meson.build
@@ -483,7 +483,6 @@ if wayland_enabled
 
   wayland_pkgs = [
     'wayland-client @0@'.format(wayland_req),
-    'wayland-protocols @0@'.format(wayland_proto_req),
     'xkbcommon @0@'.format(xkbcommon_req),
     'wayland-egl',
   ]


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]