[tracker-miners/wip/carlosg/coverity-fixes: 26/28] tracker-miner-fs: Fix use after free




commit 3817b209ec68d1779cfe5f191c47030f6f567c39
Author: Carlos Garnacho <carlosg gnome org>
Date:   Sun Oct 24 12:52:12 2021 +0200

    tracker-miner-fs: Fix use after free
    
    The variable mount_root was possibly being used after free here.
    
    CID: #365646

 src/miners/fs/tracker-miner-files.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/miners/fs/tracker-miner-files.c b/src/miners/fs/tracker-miner-files.c
index aad42354f..dafb8dbf3 100644
--- a/src/miners/fs/tracker-miner-files.c
+++ b/src/miners/fs/tracker-miner-files.c
@@ -1388,11 +1388,11 @@ mount_pre_unmount_cb (GVolumeMonitor    *volume_monitor,
 
        indexing_tree = tracker_miner_fs_get_indexing_tree (TRACKER_MINER_FS (mf));
        tracker_indexing_tree_remove (indexing_tree, mount_root);
-       g_object_unref (mount_root);
 
        /* Set mount point status in tracker-store */
        set_up_mount_point (mf, mount_root, FALSE, NULL);
 
+       g_object_unref (mount_root);
        g_free (uri);
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]