[tracker-miners/wip/carlosg/coverity-fixes: 6/28] libtracker-miner: Fix use after free




commit 3c65b3dd381c6f8e59db12678e91b13da222c77b
Author: Carlos Garnacho <carlosg gnome org>
Date:   Sun Oct 24 00:17:07 2021 +0200

    libtracker-miner: Fix use after free
    
    We were freeing data_dir right before using it for the task
    return value.
    
    CID: #365658

 src/libtracker-miner/tracker-crawler.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
---
diff --git a/src/libtracker-miner/tracker-crawler.c b/src/libtracker-miner/tracker-crawler.c
index 33c914562..a20e9fdc7 100644
--- a/src/libtracker-miner/tracker-crawler.c
+++ b/src/libtracker-miner/tracker-crawler.c
@@ -518,9 +518,8 @@ process_next (DirectoryRootInfo *info)
                } else {
                        /* No (more) children, or directory ignored. stop processing. */
                        g_queue_pop_head (info->directory_processing_queue);
-                       directory_processing_data_free (dir_data);
-
                        g_task_return_boolean (task, !dir_data->ignored_by_content);
+                       directory_processing_data_free (dir_data);
                        g_object_unref (task);
                }
        } else {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]