[gnome-shell] environment: Apply autoReverse/repeatCount to all transitions



commit cc5cc0d653ccd307475921bf069773d44b34aa5e
Author: Florian Müllner <fmuellner gnome org>
Date:   Thu Oct 21 19:50:18 2021 +0200

    environment: Apply autoReverse/repeatCount to all transitions
    
    Like the old Tweener API, ease() allows to transition multiple
    properties at once. If autoReverse or repeatCount are specified,
    they should apply to all transitions, but right now we only set
    them for the first one.
    
    Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2007>

 js/ui/environment.js | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)
---
diff --git a/js/ui/environment.js b/js/ui/environment.js
index ccd7dcdaa6..ef53e60224 100644
--- a/js/ui/environment.js
+++ b/js/ui/environment.js
@@ -201,20 +201,23 @@ function _easeActor(actor, params) {
         actor.set(params);
     actor.restore_easing_state();
 
-    let transition = animatedProps.map(p => actor.get_transition(p))
-        .find(t => t !== null);
+    const transitions = animatedProps
+        .map(p => actor.get_transition(p))
+        .filter(t => t !== null);
+
+    transitions.forEach(t => t.set({ repeatCount, autoReverse }));
+
+    const [transition] = transitions;
 
     if (transition && transition.delay)
         transition.connect('started', () => prepare());
     else
         prepare();
 
-    if (transition) {
-        transition.set({ repeatCount, autoReverse });
+    if (transition)
         transition.connect('stopped', (t, finished) => callback(finished));
-    } else {
+    else
         callback(true);
-    }
 }
 
 function _easeActorProperty(actor, propName, target, params) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]