[libadwaita/wip/exalm/dropdown-style: 5/5] stylesheet: Remove popover.combo style
- From: Alexander Mikhaylenko <alexm src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [libadwaita/wip/exalm/dropdown-style: 5/5] stylesheet: Remove popover.combo style
- Date: Mon, 18 Oct 2021 13:49:01 +0000 (UTC)
commit 264310c610f5ef5c5b6fb7ef11d51c0d5274bca6
Author: Alexander Mikhaylenko <alexm gnome org>
Date: Mon Oct 18 18:45:47 2021 +0500
stylesheet: Remove popover.combo style
It's been replaced with .menu, no need to keep it around anymore.
Update migration guide.
doc/migrating-between-development-versions.md | 8 +++++++
doc/migrating-libhandy-1-4-to-libadwaita.md | 6 +++++
src/stylesheet/widgets/_lists.scss | 32 ---------------------------
3 files changed, 14 insertions(+), 32 deletions(-)
---
diff --git a/doc/migrating-between-development-versions.md b/doc/migrating-between-development-versions.md
index 63428e1a..dcf5654c 100644
--- a/doc/migrating-between-development-versions.md
+++ b/doc/migrating-between-development-versions.md
@@ -226,3 +226,11 @@ The title and subtitle have markup enabled, make sure to escape it with
### Adapt to [class@Adw.ExpanderRow] API Changes
The `adw_expander_row_add ()` function has been renamed to `adw_expander_row_add_row ()`.
+
+### Adapt to Stylesheet Changes
+
+#### Adapt to the `popover.combo` style removal
+
+The `.combo` popover style class has been removed. Use `.menu` instead. You may
+need to remove manually added margins, padding or minimum height from the list
+items inside while doing it.
diff --git a/doc/migrating-libhandy-1-4-to-libadwaita.md b/doc/migrating-libhandy-1-4-to-libadwaita.md
index 7351cf0e..b5ceaedc 100644
--- a/doc/migrating-libhandy-1-4-to-libadwaita.md
+++ b/doc/migrating-libhandy-1-4-to-libadwaita.md
@@ -351,6 +351,12 @@ If you were using `@theme_selected_bg_color` as a text color, use
The `.sidebar` style class doesn't provide a border by default. Instead, use a
[class@Gtk.Separator] with the style class `.sidebar` manually.
+### Adapt to the `popover.combo` style removal
+
+The `.combo` popover style class has been removed. Use `.menu` instead. You may
+need to remove manually added margins, padding or minimum height from the list
+items inside while doing it.
+
#### Adapt to Header Bar, Action Bar, Search Bar and Toolbar Style Changes
When possible, buttons in [class@Gtk.HeaderBar], [class@Gtk.ActionBar] and
diff --git a/src/stylesheet/widgets/_lists.scss b/src/stylesheet/widgets/_lists.scss
index 3ec637c6..fcafc507 100644
--- a/src/stylesheet/widgets/_lists.scss
+++ b/src/stylesheet/widgets/_lists.scss
@@ -98,38 +98,6 @@ row {
* AdwComboRow *
***************/
-popover.background.combo > contents {
- padding: 0px;
-
- list, listview {
- border-style: none;
- background-color: transparent;
- min-width: 200px;
-
- > row {
- padding: 0px 12px 0px 12px;
- min-height: 50px;
- border-bottom: 1px solid $borders_color;
-
- &:first-child {
- border-top-left-radius: $popover_radius - 2;
- border-top-right-radius: $popover_radius - 2;
- }
-
- &:last-child {
- border-bottom-left-radius: $popover_radius - 2;
- border-bottom-right-radius: $popover_radius - 2;
- border-bottom: none;
- }
- }
- }
-
- scrollbar.vertical {
- padding-top: 2px;
- padding-bottom: 2px;
- }
-}
-
row.combo {
image.dropdown-arrow:disabled {
filter: opacity(.5);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]