[gnome-shell/wip/rstrode/login-screen-extensions: 2/5] extensionSystem: Get rid of _enabled boolean optimization

[Marge Bot <marge-bot src gnome org>]

commit 7e5ee2c28239036e9b24613e2f476a998cc5daf9
Author: Ray Strode <rstrode redhat com>
Date:   Tue Aug 10 13:25:57 2021 -0400

    extensionSystem: Get rid of _enabled boolean optimization
    
    At the moment a session mode either allows extensions or it doesn't.
    If it allows extensions, then the entire available list of
    configured extensions get enabled as soon as the session mode is
    entered.
    
    Since enabling or disabling extensions is an all or nothing situation,
    the code tracks whether extensions are already enabled when entering
    the session mode, and if so, avoids iterating through the extension list
    needlessly. It does this using a boolean named _enabled.
    
    In the future, the extensions themselves will be given some say on
    whether or not they should be enabled in a given session mode. This
    means, the configured extension list may contain extensions that
    shouldn't be enabled for a given session mode, and the _enabled boolean
    will no longer be appropriated.
    
    This commit drops the _enabled boolean optimization.
    
    Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1967>

 js/ui/extensionSystem.js | 10 ----------
 1 file changed, 10 deletions(-)
---
diff --git a/js/ui/extensionSystem.js b/js/ui/extensionSystem.js
index cc61cab403..5b8757d983 100644
--- a/js/ui/extensionSystem.js
+++ b/js/ui/extensionSystem.js
@@ -22,7 +22,6 @@ const UPDATE_CHECK_TIMEOUT = 24 * 60 * 60; // 1 day in seconds
 var ExtensionManager = class {
     constructor() {
         this._initialized = false;
-        this._enabled = false;
         this._updateNotified = false;
 
         this._extensions = new Map();
@@ -589,9 +588,6 @@ var ExtensionManager = class {
     }
 
     _enableAllExtensions() {
-        if (this._enabled)
-            return;
-
         if (!this._initialized) {
             this._loadExtensions();
             this._initialized = true;
@@ -600,20 +596,14 @@ var ExtensionManager = class {
                 this._callExtensionEnable(uuid);
             });
         }
-        this._enabled = true;
     }
 
     _disableAllExtensions() {
-        if (!this._enabled)
-            return;
-
         if (this._initialized) {
             this._extensionOrder.slice().reverse().forEach(uuid => {
                 this._callExtensionDisable(uuid);
             });
         }
-
-        this._enabled = false;
     }
 
     _sessionUpdated() {