[gnome-software/mwleeds/fix-deprecated-install] Add TODO comments
- From: Phaedrus Leeds <mwleeds src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software/mwleeds/fix-deprecated-install] Add TODO comments
- Date: Thu, 14 Oct 2021 02:24:22 +0000 (UTC)
commit bf5b3b439fad67cd58fe65dcb61c6af8183d26f8
Author: Phaedrus Leeds <mwleeds protonmail com>
Date: Wed Oct 13 19:24:01 2021 -0700
Add TODO comments
plugins/flatpak/gs-flatpak.c | 2 ++
plugins/flatpak/gs-self-test.c | 4 +++-
2 files changed, 5 insertions(+), 1 deletion(-)
---
diff --git a/plugins/flatpak/gs-flatpak.c b/plugins/flatpak/gs-flatpak.c
index 46bb57731..1a8682a41 100644
--- a/plugins/flatpak/gs-flatpak.c
+++ b/plugins/flatpak/gs-flatpak.c
@@ -3617,6 +3617,7 @@ gs_flatpak_file_to_app_ref (GsFlatpak *self,
} else {
remote_name = flatpak_transaction_operation_get_remote (op);
g_debug ("auto-created remote name: %s", remote_name);
+ //TODO grab metadata as needed: download size, installed size, EOL status, commit
break;
}
}
@@ -3635,6 +3636,7 @@ gs_flatpak_file_to_app_ref (GsFlatpak *self,
g_printerr ("origin_url = %s for remote %s\n", origin_url, remote_name);
/* fetch remote ref */
+ //TODO make this conditional on having the right flatpak version so that it will work
remote_ref = flatpak_installation_fetch_remote_ref_sync (self->installation,
remote_name,
flatpak_ref_get_kind (parsed_ref),
diff --git a/plugins/flatpak/gs-self-test.c b/plugins/flatpak/gs-self-test.c
index 488270c6c..843d49c05 100644
--- a/plugins/flatpak/gs-self-test.c
+++ b/plugins/flatpak/gs-self-test.c
@@ -735,7 +735,9 @@ gs_plugins_flatpak_runtime_repo_func (GsPluginLoader *plugin_loader)
/* get runtime */
runtime = gs_app_get_runtime (app);
- g_assert_cmpstr (gs_app_get_unique_id (runtime), ==, "user/flatpak/*/org.test.Runtime/master");
+ g_assert_cmpstr (gs_app_get_unique_id (runtime), ==, "user/flatpak/test/org.test.Runtime/master");
+ //TODO change this to AVAILABLE but also investigate whether it should
+ //be AVAILABLE for the app itself and related areas
g_assert_cmpint (gs_app_get_state (runtime), ==, GS_APP_STATE_AVAILABLE_LOCAL);
/* check the number of sources */
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]