[gnome-software: 102/110] gs-details-page: Simplify app bars




commit 8c4441352c66baffc85053e73d60fb9e5e97d6d4
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Tue Sep 28 17:28:11 2021 -0300

    gs-details-page: Simplify app bars
    
    We can now simply pass the icon name, instead of setting a custom widget
    as the row prefix.

 src/gs-details-page.ui | 45 +++++----------------------------------------
 1 file changed, 5 insertions(+), 40 deletions(-)
---
diff --git a/src/gs-details-page.ui b/src/gs-details-page.ui
index dfd120826..fc3ff7d4c 100644
--- a/src/gs-details-page.ui
+++ b/src/gs-details-page.ui
@@ -763,19 +763,12 @@
                                                   <object class="AdwActionRow" id="project_website_row">
                                                     <property name="activatable">True</property>
                                                     <property name="visible">True</property>
+                                                    <property 
name="icon-name">web-browser-symbolic</property>
                                                     <property name="title" translatable="yes">Project 
_Website</property>
                                                     <!-- This is a placeholder; the actual URI is set in 
code -->
                                                     <property name="subtitle">gnome.org</property>
                                                     <property name="use-underline">True</property>
                                                     <signal name="activated" 
handler="gs_details_page_link_row_activated_cb"/>
-                                                    <child type="prefix">
-                                                      <!-- Provide the prefix icon as a widget rather than 
using the icon-name property so we can set the size -->
-                                                      <object class="GtkImage">
-                                                        <property name="visible">True</property>
-                                                        <property 
name="icon-name">web-browser-symbolic</property>
-                                                        <property name="icon-size">normal</property>
-                                                      </object>
-                                                    </child>
                                                     <child>
                                                       <object class="GtkImage">
                                                         <property name="visible">True</property>
@@ -789,19 +782,12 @@
                                                   <object class="AdwActionRow" id="donate_row">
                                                     <property name="activatable">True</property>
                                                     <property name="visible">True</property>
+                                                    <property name="icon-name">money-symbolic</property>
                                                     <property name="title" 
translatable="yes">_Donate</property>
                                                     <!-- This is a placeholder; the actual URI is set in 
code -->
                                                     <property name="subtitle">gnome.org</property>
                                                     <property name="use-underline">True</property>
                                                     <signal name="activated" 
handler="gs_details_page_link_row_activated_cb"/>
-                                                    <child type="prefix">
-                                                      <!-- Provide the prefix icon as a widget rather than 
using the icon-name property so we can set the size -->
-                                                      <object class="GtkImage">
-                                                        <property name="visible">True</property>
-                                                        <property name="icon-name">money-symbolic</property>
-                                                        <property name="icon-size">normal</property>
-                                                      </object>
-                                                    </child>
                                                     <child>
                                                       <object class="GtkImage">
                                                         <property name="visible">True</property>
@@ -815,19 +801,12 @@
                                                   <object class="AdwActionRow" id="translate_row">
                                                     <property name="activatable">True</property>
                                                     <property name="visible">True</property>
+                                                    <property 
name="icon-name">flag-outline-thin-symbolic</property>
                                                     <property name="title" translatable="yes">Contribute 
_Translations</property>
                                                     <!-- This is a placeholder; the actual URI is set in 
code -->
                                                     <property name="subtitle">gnome.org</property>
                                                     <property name="use-underline">True</property>
                                                     <signal name="activated" 
handler="gs_details_page_link_row_activated_cb"/>
-                                                    <child type="prefix">
-                                                      <!-- Provide the prefix icon as a widget rather than 
using the icon-name property so we can set the size -->
-                                                      <object class="GtkImage">
-                                                        <property name="visible">True</property>
-                                                        <property 
name="icon-name">flag-outline-thin-symbolic</property>
-                                                        <property name="icon-size">normal</property>
-                                                      </object>
-                                                    </child>
                                                     <child>
                                                       <object class="GtkImage">
                                                         <property name="visible">True</property>
@@ -841,19 +820,12 @@
                                                   <object class="AdwActionRow" id="report_an_issue_row">
                                                     <property name="activatable">True</property>
                                                     <property name="visible">True</property>
+                                                    <property 
name="icon-name">computer-fail-symbolic</property>
                                                     <property name="title" translatable="yes">_Report an 
Issue</property>
                                                     <!-- This is a placeholder; the actual URI is set in 
code -->
                                                     <property name="subtitle">gnome.org</property>
                                                     <property name="use-underline">True</property>
                                                     <signal name="activated" 
handler="gs_details_page_link_row_activated_cb"/>
-                                                    <child type="prefix">
-                                                      <!-- Provide the prefix icon as a widget rather than 
using the icon-name property so we can set the size -->
-                                                      <object class="GtkImage">
-                                                        <property name="visible">True</property>
-                                                        <property 
name="icon-name">computer-fail-symbolic</property>
-                                                        <property name="icon-size">normal</property>
-                                                      </object>
-                                                    </child>
                                                     <child>
                                                       <object class="GtkImage">
                                                         <property name="visible">True</property>
@@ -867,19 +839,12 @@
                                                   <object class="AdwActionRow" id="help_row">
                                                     <property name="activatable">True</property>
                                                     <property name="visible">True</property>
+                                                    <property 
name="icon-name">help-browser-symbolic</property>
                                                     <property name="title" 
translatable="yes">_Help</property>
                                                     <!-- This is a placeholder; the actual URI is set in 
code -->
                                                     <property name="subtitle">gnome.org</property>
                                                     <property name="use-underline">True</property>
                                                     <signal name="activated" 
handler="gs_details_page_link_row_activated_cb"/>
-                                                    <child type="prefix">
-                                                      <!-- Provide the prefix icon as a widget rather than 
using the icon-name property so we can set the size -->
-                                                      <object class="GtkImage">
-                                                        <property name="visible">True</property>
-                                                        <property 
name="icon-name">help-browser-symbolic</property>
-                                                        <property name="icon-size">normal</property>
-                                                      </object>
-                                                    </child>
                                                     <child>
                                                       <object class="GtkImage">
                                                         <property name="visible">True</property>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]