[libhandy/pwood/avoid-hiding-flap-widget-when-revealing-it] flap: avoid hiding flap widget when revealing it




commit 725ed27cd0da74c7fbe69077e7efb88a37bde68c
Author: Phillip Wood <phillip wood dunelm org uk>
Date:   Mon Nov 29 14:18:16 2021 +0000

    flap: avoid hiding flap widget when revealing it
    
    If the flap widget is focused in response to the reveal_flap property
    changing then sometimes it is immediately defocused. This is because
    when the animation starts update_child_visibility() can be called with
    self->reveal_progress == 0 which hides the flap widget. Fix this by
    always showing the flap widget when self->reveal_flap != 0.

 src/hdy-flap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/hdy-flap.c b/src/hdy-flap.c
index a4791599..61e9386c 100644
--- a/src/hdy-flap.c
+++ b/src/hdy-flap.c
@@ -215,7 +215,7 @@ set_orientation (HdyFlap        *self,
 static void
 update_child_visibility (HdyFlap *self)
 {
-  gboolean visible = self->reveal_progress > 0;
+  gboolean visible = self->reveal_flap || self->reveal_progress > 0;
 
   if (self->flap.widget)
     gtk_widget_set_child_visible (self->flap.widget, visible);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]