[xdg-desktop-portal-gnome/gbsneto/post-restore-screencast-cleanups: 15/17] screencastwidget: Move margins to stack children




commit f9d33e0d9b419ff1ee1aa03c83ba9039eb246dd4
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Sun Nov 14 16:47:32 2021 -0300

    screencastwidget: Move margins to stack children
    
    GtkStack clips children while animating between pages, and
    this creates a rather unpleasant effect on listboxes shadows.
    
    Work around this by moving the margins to GtkStack pages.

 src/remotedesktopdialog.ui | 8 +++-----
 src/screencastdialog.ui    | 4 ----
 src/screencastwidget.ui    | 8 ++++++++
 3 files changed, 11 insertions(+), 9 deletions(-)
---
diff --git a/src/remotedesktopdialog.ui b/src/remotedesktopdialog.ui
index 33340ab..260fdcc 100644
--- a/src/remotedesktopdialog.ui
+++ b/src/remotedesktopdialog.ui
@@ -39,11 +39,6 @@
             <property name="child">
               <object class="GtkBox">
                 <property name="orientation">vertical</property>
-                <property name="margin-top">32</property>
-                <property name="margin-bottom">32</property>
-                <property name="margin-start">32</property>
-                <property name="margin-end">32</property>
-                <property name="spacing">32</property>
                 <property name="hexpand">1</property>
                 <property name="vexpand">1</property>
                 <child>
@@ -55,6 +50,9 @@
                 <child>
                   <object class="GtkBox">
                     <property name="spacing">6</property>
+                    <property name="margin-bottom">32</property>
+                    <property name="margin-start">32</property>
+                    <property name="margin-end">32</property>
                     <property name="orientation">vertical</property>
                     <child>
                       <object class="GtkLabel" id="device_heading">
diff --git a/src/screencastdialog.ui b/src/screencastdialog.ui
index b0fffb0..14751fd 100644
--- a/src/screencastdialog.ui
+++ b/src/screencastdialog.ui
@@ -40,10 +40,6 @@
             <property name="child">
               <object class="GtkBox">
                 <property name="orientation">vertical</property>
-                <property name="margin-top">32</property>
-                <property name="margin-bottom">32</property>
-                <property name="margin-start">32</property>
-                <property name="margin-end">32</property>
                 <property name="hexpand">1</property>
                 <property name="vexpand">1</property>
                 <child>
diff --git a/src/screencastwidget.ui b/src/screencastwidget.ui
index f65b858..f6bb7e9 100644
--- a/src/screencastwidget.ui
+++ b/src/screencastwidget.ui
@@ -16,6 +16,10 @@
             <property name="title" translatable="yes">Single Window</property>
             <property name="child">
               <object class="GtkBox" id="window_selection">
+                <property name="margin-top">32</property>
+                <property name="margin-bottom">32</property>
+                <property name="margin-start">32</property>
+                <property name="margin-end">32</property>
                 <property name="orientation">vertical</property>
                 <property name="visible">0</property>
                 <property name="spacing">12</property>
@@ -60,6 +64,10 @@
             <property name="child">
               <object class="GtkBox" id="monitor_selection">
                 <property name="visible">0</property>
+                <property name="margin-top">32</property>
+                <property name="margin-bottom">32</property>
+                <property name="margin-start">32</property>
+                <property name="margin-end">32</property>
                 <property name="orientation">vertical</property>
                 <property name="spacing">12</property>
                 <child>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]