[gnome-characters/bilelmoussaoui/gtk4: 8/27] UI: remove useless properties

From: Bilal Elmoussaoui <bilelmoussaoui src gnome org>
To: commits-list gnome org
Cc:
Subject: [gnome-characters/bilelmoussaoui/gtk4: 8/27] UI: remove useless properties
Date: Sun, 21 Nov 2021 14:35:44 +0000 (UTC)

commit 36d6b2cd96a53aa32b1314d9ffc4aa8fbce483f0
Author: Bilal Elmoussaoui <bil elmoussaoui gmail com>
Date:   Fri Nov 19 12:07:31 2021 +0100

    UI: remove useless properties

 data/character.ui     | 313 +++++++++++++++++++++++---------------------------
 data/characterlist.ui |  62 +++++-----
 data/mainview.ui      |  18 +--
 data/mainwindow.ui    |  47 +-------
 data/menu.ui          |   6 -
 5 files changed, 191 insertions(+), 255 deletions(-)
---
diff --git a/data/character.ui b/data/character.ui
index 6b96612..b31d399 100644
--- a/data/character.ui
+++ b/data/character.ui
@@ -1,171 +1,150 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <interface>
-  <template class="Gjs_CharacterDialog" parent="GtkDialog">
-    <child internal-child="vbox">
-      <object class="GtkBox" id="vbox1">
-       <child>
-         <object class="GtkStack" id="main-stack">
-           <property name="visible">True</property>
-           <child>
-             <object class="GtkGrid" id="character-grid">
-               <property name="visible">True</property>
-               <property name="can_focus">False</property>
-               <property name="halign">fill</property>
-               <property name="valign">center</property>
-               <property name="border_width">5</property>
-               <property name="orientation">vertical</property>
-               <property name="row_spacing">50</property>
-               <child>
-                 <object class="GtkStack" id="character-stack">
-                   <property name="visible">True</property>
-                   <child>
-                     <object class="GtkLabel" id="character-label">
-                       <property name="visible">True</property>
-                       <property name="can_focus">False</property>
-                       <property name="ellipsize">end</property>
-                       <property name="halign">center</property>
-                       <property name="valign">center</property>
-                       <style>
-                         <class name="character-label"/>
-                       </style>
-                     </object>
-                     <packing>
-                       <property name="name">character</property>
-                     </packing>
-                   </child>
-                   <child>
-                     <object class="GtkLabel" id="missing-label">
-                       <property name="visible">True</property>
-                       <property name="can_focus">False</property>
-                       <property name="halign">center</property>
-                       <property name="valign">center</property>
-                       <property name="wrap">True</property>
-                       <property name="wrap-mode">word</property>
-                       <property name="width-chars">28</property>
-                       <property name="max-width-chars">28</property>
-                       <property name="justify">center</property>
-                       <style>
-                         <class name="missing-label"/>
-                       </style>
-                     </object>
-                     <packing>
-                       <property name="name">missing</property>
-                     </packing>
-                   </child>
-                 </object>
-                 <packing>
-                   <property name="left_attach">0</property>
-                   <property name="top_attach">0</property>
-                 </packing>
-               </child>
-               <child>
-                 <object class="GtkBox" id="vbox2">
-                   <property name="visible">True</property>
-                   <property name="orientation">vertical</property>
-                   <child>
-                     <object class="GtkButton" id="copy-button">
-                       <property name="label" translatable="yes">Copy Character</property>
-                       <property name="visible">True</property>
-                       <property name="can_focus">True</property>
-                       <property name="receives_default">False</property>
-                       <property name="halign">center</property>
-                     </object>
-                   </child>
-                   <child>
-                     <object class="GtkOverlay" id="overlay">
-                       <property name="visible">True</property>
-                       <property name="can_focus">False</property>
-                       <child type="overlay">
-                         <object class="GtkRevealer" id="copy-revealer">
-                           <property name="visible">True</property>
-                           <property name="can_focus">False</property>
-                           <property name="transition-type">crossfade</property>
-                           <child>
-                             <object class="GtkLabel" id="copy-label">
-                               <property name="label" translatable="yes">Character copied to 
clipboard</property>
-                               <property name="visible">True</property>
-                               <property name="can_focus">False</property>
-                               <property name="ellipsize">end</property>
-                               <property name="halign">center</property>
-                               <property name="hexpand">True</property>
-                               <property name="valign">center</property>
-                             </object>
-                           </child>
-                         </object>
-                       </child>
-                       <child>
-                         <object class="GtkLabel" id="placeholder-label">
-                           <property name="visible">True</property>
-                           <property name="can_focus">False</property>
-                           <property name="halign">center</property>
-                           <property name="valign">center</property>
-                           <style>
-                             <class name="character-notification"/>
-                           </style>
-                         </object>
-                       </child>
-                     </object>
-                   </child>
-                 </object>
-                 <packing>
-                   <property name="left_attach">0</property>
-                   <property name="top_attach">1</property>
-                 </packing>
-               </child>
-               <child>
-                 <object class="GtkLabel" id="detail-label">
-                   <property name="visible">True</property>
-                   <property name="can_focus">False</property>
-                   <property name="halign">center</property>
-                   <property name="selectable">True</property>
-                   <style>
-                     <class name="detail-label"/>
-                   </style>
-                 </object>
-                 <packing>
-                   <property name="left_attach">0</property>
-                   <property name="top_attach">2</property>
-                 </packing>
-               </child>
-             </object>
-             <packing>
-               <property name="name">character</property>
-             </packing>
-           </child>
-           <child>
-             <object class="GtkScrolledWindow" id="related-scrolled">
-               <property name="visible">True</property>
-               <property name="can_focus">False</property>
-               <property name="margin_start">6</property>
-               <property name="margin_end">6</property>
-               <property name="margin_top">6</property>
-               <property name="margin_bottom">6</property>
-               <property name="hscrollbar_policy">never</property>
-               <property name="vexpand">True</property>
-               <style>
-                 <class name="related"/>
-               </style>
-               <child>
-                 <object class="GtkViewport" id="related-viewport">
-                   <child>
-                     <object class="GtkListBox" id="related-listbox">
-                       <property name="visible">True</property>
-                       <property name="can_focus">False</property>
-                       <child>
-                         <placeholder/>
-                       </child>
-                     </object>
-                   </child>
-                 </object>
-               </child>
-             </object>
-             <packing>
-               <property name="name">related</property>
-             </packing>
-           </child>
-         </object>
-       </child>
-      </object>
+<template class="Gjs_CharacterDialog" parent="GtkDialog">
+  <child internal-child="vbox">
+   <object class="GtkBox" id="vbox1">
+    <child>
+     <object class="GtkStack" id="main-stack">
+      <child>
+       <object class="GtkGrid" id="character-grid">
+          <property name="halign">fill</property>
+          <property name="valign">center</property>
+          <property name="border_width">5</property>
+          <property name="orientation">vertical</property>
+          <property name="row_spacing">50</property>
+          <child>
+             <object class="GtkStack" id="character-stack">
+                <child>
+                   <object class="GtkLabel" id="character-label">
+                      <property name="ellipsize">end</property>
+                      <property name="halign">center</property>
+                      <property name="valign">center</property>
+                      <style>
+                         <class name="character-label" />
+                      </style>
+                   </object>
+                   <packing>
+                      <property name="name">character</property>
+                   </packing>
+                </child>
+                <child>
+                   <object class="GtkLabel" id="missing-label">
+                      <property name="halign">center</property>
+                      <property name="valign">center</property>
+                      <property name="wrap">True</property>
+                      <property name="wrap-mode">word</property>
+                      <property name="width-chars">28</property>
+                      <property name="max-width-chars">28</property>
+                      <property name="justify">center</property>
+                      <style>
+                         <class name="missing-label" />
+                      </style>
+                   </object>
+                   <packing>
+                      <property name="name">missing</property>
+                   </packing>
+                </child>
+             </object>
+             <packing>
+                <property name="left_attach">0</property>
+                <property name="top_attach">0</property>
+             </packing>
+          </child>
+          <child>
+             <object class="GtkBox" id="vbox2">
+                <property name="orientation">vertical</property>
+                <child>
+                   <object class="GtkButton" id="copy-button">
+                      <property name="label" translatable="yes">Copy Character</property>
+                      <property name="can_focus">True</property>
+                      <property name="receives_default">False</property>
+                      <property name="halign">center</property>
+                   </object>
+                </child>
+                <child>
+                   <object class="GtkOverlay" id="overlay">
+                      <child type="overlay">
+                         <object class="GtkRevealer" id="copy-revealer">
+                            <property name="can_focus">False</property>
+                            <property name="transition-type">crossfade</property>
+                            <child>
+                               <object class="GtkLabel" id="copy-label">
+                                  <property name="label" translatable="yes">Character copied to 
clipboard</property>
+                                  <property name="can_focus">False</property>
+                                  <property name="ellipsize">end</property>
+                                  <property name="halign">center</property>
+                                  <property name="hexpand">True</property>
+                                  <property name="valign">center</property>
+                               </object>
+                            </child>
+                         </object>
+                      </child>
+                      <child>
+                         <object class="GtkLabel" id="placeholder-label">
+                            <property name="can_focus">False</property>
+                            <property name="halign">center</property>
+                            <property name="valign">center</property>
+                            <style>
+                               <class name="character-notification" />
+                            </style>
+                         </object>
+                      </child>
+                   </object>
+                </child>
+             </object>
+             <packing>
+                <property name="left_attach">0</property>
+                <property name="top_attach">1</property>
+             </packing>
+          </child>
+          <child>
+             <object class="GtkLabel" id="detail-label">
+                <property name="can_focus">False</property>
+                <property name="halign">center</property>
+                <property name="selectable">True</property>
+                <style>
+                   <class name="detail-label" />
+                </style>
+             </object>
+             <packing>
+                <property name="left_attach">0</property>
+                <property name="top_attach">2</property>
+             </packing>
+          </child>
+       </object>
+       <packing>
+          <property name="name">character</property>
+       </packing>
+      </child>
+      <child>
+       <object class="GtkScrolledWindow" id="related-scrolled">
+        <property name="can_focus">False</property>
+        <property name="margin_start">6</property>
+        <property name="margin_end">6</property>
+        <property name="margin_top">6</property>
+        <property name="margin_bottom">6</property>
+        <property name="hscrollbar_policy">never</property>
+        <property name="vexpand">True</property>
+        <style>
+          <class name="related" />
+        </style>
+        <child>
+          <object class="GtkViewport" id="related-viewport">
+            <child>
+              <object class="GtkListBox" id="related-listbox" />
+            </child>
+          </object>
+        </child>
+       </object>
+       <packing>
+          <property name="name">related</property>
+       </packing>
+      </child>
+     </object>
     </child>
-  </template>
+   </object>
+  </child>
+</template>
 </interface>
+
+
diff --git a/data/characterlist.ui b/data/characterlist.ui
index eabd916..c44de43 100644
--- a/data/characterlist.ui
+++ b/data/characterlist.ui
@@ -1,45 +1,45 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <interface>
   <template class="Gjs_CharacterListView" parent="GtkStack">
-    <property name="visible">True</property>
     <child>
-      <object class="AdwStatusPage">
-        <property name="icon-name">system-search-symbolic</property>
-        <property name="title" translatable="yes">No Results</property>
-        <property name="description" translatable="yes">Try a different search.</property>
-      </object>
-      <packing>
+      <object class="GtkStackPage">
         <property name="name">unavailable</property>
-      </packing>
+        <property name="child">
+          <object class="AdwStatusPage">
+            <property name="icon-name">system-search-symbolic</property>
+            <property name="title" translatable="yes">No Results</property>
+            <property name="description" translatable="yes">Try a different search.</property>
+          </object>
+        </property>
+      </object>
     </child>
     <child>
-      <object class="GtkGrid" id="loading-grid">
-        <property name="visible">False</property>
-        <property name="halign">center</property>
-        <property name="valign">center</property>
-        <style>
-          <class name="banner"/>
-        </style>
-        <child>
-          <object class="GtkSpinner" id="loading-spinner">
-            <property name="visible">True</property>
-            <property name="width-request">128</property>
-            <property name="height-request">128</property>
-          </object>
-        </child>
-        <child>
-          <object class="GtkLabel" id="loading-label">
-            <property name="visible">True</property>
-            <property name="label" translatable="yes">Loading…</property>
+      <object class="GtkStackPage">
+        <property name="name">loading</property>
+        <property name="child">
+          <object class="GtkGrid" id="loading-grid">
+            <property name="halign">center</property>
+            <property name="valign">center</property>
             <style>
-              <class name="banner-label"/>
+              <class name="banner"/>
             </style>
+            <child>
+              <object class="GtkSpinner" id="loading-spinner">
+                <property name="width-request">128</property>
+                <property name="height-request">128</property>
+              </object>
+            </child>
+            <child>
+              <object class="GtkLabel" id="loading-label">
+                <property name="label" translatable="yes">Loading…</property>
+                <style>
+                  <class name="banner-label"/>
+                </style>
+              </object>
+            </child>
           </object>
-        </child>
+        </property>
       </object>
-      <packing>
-        <property name="name">loading</property>
-      </packing>
     </child>
   </template>
 </interface>
diff --git a/data/mainview.ui b/data/mainview.ui
index ccae099..b787b35 100644
--- a/data/mainview.ui
+++ b/data/mainview.ui
@@ -1,17 +1,17 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <interface>
   <template class="Gjs_MainView" parent="GtkStack">
-    <property name="visible">True</property>
     <child>
-      <object class="AdwStatusPage">
-        <property name="visible">True</property>
-        <property name="icon_name">characters-punctuation-symbolic</property>
-        <property name="title" translatable="yes">No Recent Characters</property>
-        <property name="description" translatable="yes">Characters will appear here if you use 
them.</property>
-      </object>
-      <packing>
+      <object class="GtkStackPage">
         <property name="name">empty-recent</property>
-      </packing>
+        <property name="child">
+          <object class="AdwStatusPage">
+            <property name="icon_name">characters-punctuation-symbolic</property>
+            <property name="title" translatable="yes">No Recent Characters</property>
+            <property name="description" translatable="yes">Characters will appear here if you use 
them.</property>
+          </object>
+        </property>
+      </object>
     </child>
   </template>
 </interface>
diff --git a/data/mainwindow.ui b/data/mainwindow.ui
index 8cd7039..021dc9e 100644
--- a/data/mainwindow.ui
+++ b/data/mainwindow.ui
@@ -13,22 +13,18 @@
     </section>
   </menu>
   <template class="Gjs_MainWindow" parent="AdwApplicationWindow">
-    <property name="height-request">660</property>
     <property name="default-width">800</property>
     <property name="default-height">500</property>
     <child>
       <object class="AdwLeaflet" id="leaflet">
-        <property name="visible">True</property>
         <property name="can-navigate-back">True</property>
         <child>
           <object class="GtkBox">
             <property name="orientation">vertical</property>
-            <property name="visible">True</property>
             <property name="width-request">280</property>
             <child>
               <object class="GtkHeaderBar" id="sidebar-headerbar">
-                <property name="visible">True</property>
-                <property name="show-title-buttons">True</property>
+                <property name="show-title-buttons">False</property>
                 <property name="title-widget">
                   <object class="AdwWindowTitle">
                     <property name="title" translatable="yes">Characters</property>
@@ -36,44 +32,27 @@
                 </property>
                 <child>
                   <object class="GtkToggleButton" id="search-active-button">
-                    <property name="can_focus">True</property>
-                    <property name="visible">True</property>
-                    <child>
-                      <object class="GtkImage" id="search-button-image">
-                        <property name="visible">True</property>
-                        <property name="icon-name">edit-find-symbolic</property>
-                      </object>
-                    </child>
+                    <property name="icon-name">edit-find-symbolic</property>
                   </object>
                 </child>
                 <child type="end">
                   <object class="GtkMenuButton">
-                    <property name="visible">True</property>
                     <property name="menu-model">primary_menu</property>
-                    <child>
-                      <object class="GtkImage">
-                        <property name="visible">True</property>
-                        <property name="icon-name">open-menu-symbolic</property>
-                      </object>
-                    </child>
+                    <property name="icon-name">open-menu-symbolic</property>
                   </object>
                 </child>
               </object>
             </child>
             <child>
               <object class="GtkBox" id="sidebar">
-                <property name="visible">True</property>
                 <property name="hexpand">False</property>
                 <property name="vexpand">True</property>
                 <property name="orientation">vertical</property>
                 <child>
                   <object class="GtkSearchBar" id="search-bar">
-                    <property name="visible">True</property>
                     <property name="halign">fill</property>
                     <child>
                       <object class="GtkSearchEntry" id="search-entry">
-                        <property name="can_focus">True</property>
-                        <property name="visible">True</property>
                         <property name="halign">fill</property>
                       </object>
                     </child>
@@ -86,10 +65,8 @@
         <child>
           <object class="GtkBox">
             <property name="orientation">vertical</property>
-            <property name="visible">True</property>
             <child>
               <object class="GtkSeparator">
-                <property name="visible">True</property>
                 <property name="orientation">vertical</property>
                 <style>
                   <class name="sidebar"/>
@@ -98,8 +75,6 @@
             </child>
             <child>
               <object class="GtkSeparator">
-                <property name="visible">True</property>
-                <property name="can_focus">False</property>
                 <property name="orientation">vertical</property>
                 <property name="vexpand">True</property>
                 <style>
@@ -112,34 +87,22 @@
         <child>
           <object class="GtkBox" id="container">
             <property name="orientation">vertical</property>
-            <property name="visible">True</property>
             <child>
               <object class="GtkHeaderBar" id="main-headerbar">
-                <property name="visible">True</property>
                 <property name="show-title-buttons">True</property>
                 <child>
                   <object class="GtkRevealer">
                     <property name="transition-type">crossfade</property>
-                    <property name="visible">True</property>
                     <property name="reveal-child" bind-source="leaflet" bind-property="folded" 
bind-flags="sync-create" />
                     <child>
                       <object class="GtkButton" id="back-button">
-                        <property name="can_focus">True</property>
-                        <property name="visible">True</property>
-                        <child>
-                          <object class="GtkImage" id="back-button-image">
-                            <property name="visible">True</property>
-                            <property name="icon-name">go-previous-symbolic</property>
-                          </object>
-                        </child>
+                        <property name="icon-name">go-previous-symbolic</property>
                       </object>
                     </child>
                   </object>
                 </child>
-                <child>
+                <child type="end">
                   <object class="GtkMenuButton" id="menu-button">
-                    <property name="can_focus">False</property>
-                    <property name="visible">True</property>
                     <property name="icon-name">view-more-symbolic</property>
                   </object>
                 </child>
diff --git a/data/menu.ui b/data/menu.ui
index 651a0b0..968e58e 100644
--- a/data/menu.ui
+++ b/data/menu.ui
@@ -5,7 +5,6 @@
     <property name="width-request">250</property>
     <child>
       <object class="GtkBox">
-        <property name="visible">True</property>
         <property name="orientation">vertical</property>
         <property name="margin-top">12</property>
         <property name="margin-bottom">12</property>
@@ -14,7 +13,6 @@
         <property name="spacing">12</property>
         <child>
           <object class="GtkLabel">
-            <property name="visible">True</property>
             <property name="halign">center</property>
             <property name="label" translatable="yes">Filter by Font</property>
             <attributes>
@@ -24,19 +22,15 @@
         </child>
         <child>
           <object class="GtkSearchEntry" id="search-entry">
-            <property name="can_focus">True</property>
-            <property name="visible">True</property>
             <property name="halign">fill</property>
           </object>
         </child>
         <child>
           <object class="GtkScrolledWindow">
-            <property name="visible">True</property>
             <property name="vexpand">True</property>
             <property name="hscrollbar_policy">never</property>
             <child>
               <object class="GtkListBox" id="font-listbox">
-                <property name="visible">True</property>
                 <property name="selection_mode">single</property>
                 <style>
                   <class name="content" />
[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]