[devdocsgjs/main: 788/1867] Fix #1049




commit 22094f7dcf2e00823300a3e48e19b5a94bbf6ff1
Author: Jasper van Merle <jaspervmerle gmail com>
Date:   Mon Aug 12 13:10:41 2019 +0200

    Fix #1049

 assets/javascripts/lib/page.coffee              | 4 ++--
 assets/javascripts/views/layout/document.coffee | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/assets/javascripts/lib/page.coffee b/assets/javascripts/lib/page.coffee
index ba2f2647..ea20000b 100644
--- a/assets/javascripts/lib/page.coffee
+++ b/assets/javascripts/lib/page.coffee
@@ -208,12 +208,12 @@ track = ->
     # Only ask for consent once per browser session
     Cookies.set('analyticsConsentAsked', '1')
 
-    new app.views.Notif 'AnalyticsConsent', autoHide: null
+    new app.views.Notif 'AnalyticsConsent', autoHide: false
   return
 
 @resetAnalytics = ->
   for cookie in document.cookie.split(/;\s?/)
     name = cookie.split('=')[0]
-    if name[0] == '_'
+    if name[0] == '_' && name[1] != '_'
       Cookies.expire(name)
   return
diff --git a/assets/javascripts/views/layout/document.coffee b/assets/javascripts/views/layout/document.coffee
index 597dfe37..a10d0b3c 100644
--- a/assets/javascripts/views/layout/document.coffee
+++ b/assets/javascripts/views/layout/document.coffee
@@ -80,6 +80,6 @@ class app.views.Document extends app.View
       when 'reboot'             then app.reboot()
       when 'hard-reload'        then app.reload()
       when 'reset'              then app.reset() if confirm('Are you sure you want to reset DevDocs?')
-      when 'accept-analytics'   then Cookies.set('analyticsConsent', '1') && app.reboot()
-      when 'decline-analytics'  then Cookies.set('analyticsConsent', '0') && app.reboot()
+      when 'accept-analytics'   then Cookies.set('analyticsConsent', '1', expires: 1e8) && app.reboot()
+      when 'decline-analytics'  then Cookies.set('analyticsConsent', '0', expires: 1e8) && app.reboot()
     return


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]